ENABLE_CHECKING refactoring: remove remaining occurrences

libcpp/

	* config.in: Regenerate.
	* configure: Regenerate.
	* configure.ac: Remove ENABLE_CHECKING.

gcc/

	* cfganal.c (inverted_post_order_compute): Remove conditional
	compilation, use flag_checking.
	* config.in: Regenerate.
	* configure: Regenerate.
	* configure.ac: Remove ENABLE_CHECKING.
	* genconditions.c: Do not #undef ENABLE_CHECKING.
	* sese.h (bb_in_region): Comment out broken check.
	* tree-ssa-loop-manip.c (rewrite_into_loop_closed_ssa_1): Remove
	conditional compilation, use flag_checking.

From-SVN: r229758

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 9304d780e2974aa3576750d62f9881cfec87af99..b41693d306bff81928a1c3f910d9f37a7dfa8139 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,15 @@
+2015-11-04  Mikhail Maltsev  <maltsevm@gmail.com>
+
+       * cfganal.c (inverted_post_order_compute): Remove conditional
+       compilation, use flag_checking.
+       * config.in: Regenerate.
+       * configure: Regenerate.
+       * configure.ac: Remove ENABLE_CHECKING.
+       * genconditions.c: Do not #undef ENABLE_CHECKING.
+       * sese.h (bb_in_region): Comment out broken check.
+       * tree-ssa-loop-manip.c (rewrite_into_loop_closed_ssa_1): Remove
+       conditional compilation, use flag_checking.
+
 2015-11-04  Tom de Vries  <tom@codesourcery.com>
 
        PR tree-optimization/67742

diff --git a/gcc/cfganal.c b/gcc/cfganal.c
index 6f3e3488877d072fe9ee97c96ffa5643c36690c1..0f26038b22b2e61e5a0bb1386281770d1b9b2495 100644 (file)
--- a/gcc/cfganal.c
+++ b/gcc/cfganal.c
@@ -784,9 +784,8 @@ inverted_post_order_compute (int *post_order)
   int post_order_num = 0;
   sbitmap visited;
 
-#if ENABLE_CHECKING
-  verify_no_unreachable_blocks ();
-#endif
+  if (flag_checking)
+    verify_no_unreachable_blocks ();
 
   /* Allocate stack for back-tracking up CFG.  */
   stack = XNEWVEC (edge_iterator, n_basic_blocks_for_fn (cfun) + 1);

diff --git a/gcc/config.in b/gcc/config.in
index 48d7e6441e6bed5c1f82f1ea26c75ccc09ef647a..6f46f7039bd2f53a1b430a38a7abfcce1eaae810 100644 (file)
--- a/gcc/config.in
+++ b/gcc/config.in
@@ -76,13 +76,6 @@
 #endif
 
 
-/* Define if you want more run-time sanity checks. This one gets a grab bag of
-   miscellaneous but relatively cheap checks. */
-#ifndef USED_FOR_TARGET
-#undef ENABLE_CHECKING
-#endif
-
-
 /* Define to 1 to specify that we are using the BID decimal floating point
    format instead of DPD */
 #ifndef USED_FOR_TARGET

diff --git a/gcc/configure b/gcc/configure
index 92bda6c759e48a69701f73abf0dacf8c20109423..1d2e8f2644dab096f44918ce08631eaef828b553 100755 (executable)
--- a/gcc/configure
+++ b/gcc/configure
@@ -7098,9 +7098,6 @@ IFS="$ac_save_IFS"
 nocommon_flag=""
 if test x$ac_checking != x ; then
 
-$as_echo "#define ENABLE_CHECKING 1" >>confdefs.h
-
-
 $as_echo "#define CHECKING_P 1" >>confdefs.h
 
   nocommon_flag=-fno-common
@@ -18405,7 +18402,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18408 "configure"
+#line 18405 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -18511,7 +18508,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18514 "configure"
+#line 18511 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H

diff --git a/gcc/configure.ac b/gcc/configure.ac
index 7e22267e3bb9f1a477b3226ff054bc60a77e19f9..d03a0bd1c17cf9515daebcd867c692a00a9b916f 100644 (file)
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -566,9 +566,6 @@ IFS="$ac_save_IFS"
 
 nocommon_flag=""
 if test x$ac_checking != x ; then
-  AC_DEFINE(ENABLE_CHECKING, 1,
-[Define if you want more run-time sanity checks.  This one gets a grab
-   bag of miscellaneous but relatively cheap checks.])
   AC_DEFINE(CHECKING_P, 1,
 [Define to 1 if you want more run-time sanity checks.  This one gets a grab
    bag of miscellaneous but relatively cheap checks.])

diff --git a/gcc/genconditions.c b/gcc/genconditions.c
index 7481ab41d5e5bad78dd0b46ea71e660809829724..dd5bc92922105c43d1643a01571cff19cc3bb566 100644 (file)
--- a/gcc/genconditions.c
+++ b/gcc/genconditions.c
@@ -59,7 +59,6 @@ write_header (void)
 #if GCC_VERSION >= 3001\n\
 \n\
 /* Do not allow checking to confuse the issue.  */\n\
-#undef ENABLE_CHECKING\n\
 #undef CHECKING_P\n\
 #define CHECKING_P 0\n\
 #undef ENABLE_TREE_CHECKING\n\

diff --git a/gcc/sese.h b/gcc/sese.h
index d2ad9bde04b88145f5a329c0bd79f2d3d87cbfce..98ab4911e20660d4745559685088fe297cb0f2df 100644 (file)
--- a/gcc/sese.h
+++ b/gcc/sese.h
@@ -108,16 +108,18 @@ sese_nb_params (sese_info_p region)
 static inline bool
 bb_in_region (basic_block bb, basic_block entry, basic_block exit)
 {
-#ifdef ENABLE_CHECKING
-  {
-    edge e;
-    edge_iterator ei;
-
-    /* Check that there are no edges coming in the region: all the
-       predecessors of EXIT are dominated by ENTRY.  */
-    FOR_EACH_EDGE (e, ei, exit->preds)
-      dominated_by_p (CDI_DOMINATORS, e->src, entry);
-  }
+  /* FIXME: PR67842.  */
+#if 0
+  if (flag_checking)
+    {
+      edge e;
+      edge_iterator ei;
+
+      /* Check that there are no edges coming in the region: all the
+        predecessors of EXIT are dominated by ENTRY.  */
+      FOR_EACH_EDGE (e, ei, exit->preds)
+       gcc_assert (dominated_by_p (CDI_DOMINATORS, e->src, entry));
+    }
 #endif
 
   return dominated_by_p (CDI_DOMINATORS, bb, entry)

diff --git a/gcc/tree-ssa-loop-manip.c b/gcc/tree-ssa-loop-manip.c
index db797cc0b67ed9d10950111652eda3a468a287cc..b614412e3f12c3ccdb7c55ac1f8446124278342b 100644 (file)
--- a/gcc/tree-ssa-loop-manip.c
+++ b/gcc/tree-ssa-loop-manip.c
@@ -616,14 +616,10 @@ rewrite_into_loop_closed_ssa_1 (bitmap changed_bbs, unsigned update_flag,
 
   /* If the pass has caused the SSA form to be out-of-date, update it
      now.  */
-  if (update_flag == 0)
-    {
-#ifdef ENABLE_CHECKING
-      verify_ssa (true, true);
-#endif
-    }
-  else
+  if (update_flag != 0)
     update_ssa (update_flag);
+  else if (flag_checking)
+    verify_ssa (true, true);
 
   bitmap_obstack_initialize (&loop_renamer_obstack);
 

diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog
index 61b0177dd5102a5bb0d644ba9ba8fd4b76d49692..f2ce57abebd881c24c4bf81f53d12517b18f4021 100644 (file)
--- a/libcpp/ChangeLog
+++ b/libcpp/ChangeLog
@@ -1,3 +1,9 @@
+2015-11-04  Mikhail Maltsev  <maltsevm@gmail.com>
+
+       * config.in: Regenerate.
+       * configure: Regenerate.
+       * configure.ac: Remove ENABLE_CHECKING.
+
 2015-11-03  Uros Bizjak  <ubizjak@gmail.com>
 
        * lex.c (search_line_sse42): Correctly advance the pointer to an

diff --git a/libcpp/config.in b/libcpp/config.in
index 5865eb363fc84d84e19a60ac876d38b3a4a7178a..e02ac5efbadbdd2a7d9bd349dcd0e766b95e3d64 100644 (file)
--- a/libcpp/config.in
+++ b/libcpp/config.in
@@ -17,9 +17,6 @@
 /* Define to enable system headers canonicalization. */
 #undef ENABLE_CANONICAL_SYSTEM_HEADERS
 
-/* Define if you want more run-time sanity checks. */
-#undef ENABLE_CHECKING
-
 /* Define to 1 if translation of program messages to the user's native
    language is requested. */
 #undef ENABLE_NLS

diff --git a/libcpp/configure b/libcpp/configure
index 1c70c75eb4457ceca767e3c5e8a92e72e120cad8..0342f163c9cbccab28dbbf9efaf0c4beed241e47 100755 (executable)
--- a/libcpp/configure
+++ b/libcpp/configure
@@ -7298,9 +7298,7 @@ IFS="$ac_save_IFS"
 
 if test x$ac_checking != x ; then
 
-$as_echo "#define ENABLE_CHECKING 1" >>confdefs.h
-
-  $as_echo "#define CHECKING_P 1" >>confdefs.h
+$as_echo "#define CHECKING_P 1" >>confdefs.h
 
 else
   $as_echo "#define CHECKING_P 0" >>confdefs.h

diff --git a/libcpp/configure.ac b/libcpp/configure.ac
index 3fcbe84f33e9e61753d3c34701ee141b45e2d68e..0005c589fcda623bc0fb2ee0be1eaf32e3244208 100644 (file)
--- a/libcpp/configure.ac
+++ b/libcpp/configure.ac
@@ -164,8 +164,6 @@ done
 IFS="$ac_save_IFS"
                 
 if test x$ac_checking != x ; then
-  AC_DEFINE(ENABLE_CHECKING, 1,
-[Define if you want more run-time sanity checks.])
   AC_DEFINE(CHECKING_P, 1,
 [Define to 1 if you want more run-time sanity checks.])
 else