linux-nat: Remove unnecessary xstrdup

I think this xstrdup is not useful.  We can pass ex.message directly to
throw_error instead.

gdb/ChangeLog:

	* linux-nat.c (linux_nat_attach): Remove xstrdup.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ad6174ba927e0641f20ad69e95962eed1e3e520a..2a75839e41a0939eefb1a02431aa7b678034cb5e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-01-17  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * linux-nat.c (linux_nat_attach): Remove xstrdup.
+
 2018-01-17  Eldar Abusalimov  <eldar.abusalimov@jetbrains.com>
 
        PR gdb/21559

diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index c41ea391a0b8c1a416e8e6356a6ed6dcd808131e..d26ab7d5d78bb9b140c1be0c852f6c73a88054b4 100644 (file)
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -1224,10 +1224,7 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty)
     {
       pid_t pid = parse_pid_to_attach (args);
       struct buffer buffer;
-      char *message, *buffer_s;
-
-      message = xstrdup (ex.message);
-      make_cleanup (xfree, message);
+      char *buffer_s;
 
       buffer_init (&buffer);
       linux_ptrace_attach_fail_reason (pid, &buffer);
@@ -1237,9 +1234,9 @@ linux_nat_attach (struct target_ops *ops, const char *args, int from_tty)
       make_cleanup (xfree, buffer_s);
 
       if (*buffer_s != '\0')
-       throw_error (ex.error, "warning: %s\n%s", buffer_s, message);
+       throw_error (ex.error, "warning: %s\n%s", buffer_s, ex.message);
       else
-       throw_error (ex.error, "%s", message);
+       throw_error (ex.error, "%s", ex.message);
     }
   END_CATCH