radeon/winsys: pad IBs to a multiple of 8 DWs
authorAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Sep 2013 20:43:34 +0000 (16:43 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Sep 2013 23:08:35 +0000 (19:08 -0400)
This aligns the gfx, compute, and dma IBs to 8 DW boundries.
This aligns the the IB to the fetch size of the CP for optimal
performance. Additionally, r6xx hardware requires at least 4
DW alignment to avoid a hw bug.  This also aligns the DMA
IBs to 8 DW which is required for the DMA engine.  This
alignment is already handled in the gallium driver, but that
patch can be removed now that it's done in the winsys.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
CC: "9.2" <mesa-stable@lists.freedesktop.org>
CC: "9.1" <mesa-stable@lists.freedesktop.org>
src/gallium/winsys/radeon/drm/radeon_drm_cs.c

index ea0c99df3fa13c770ba23d7e269e1d8e75940ff5..38a92095507dac11b9989570d740854e0cd475a9 100644 (file)
@@ -466,6 +466,36 @@ static void radeon_drm_cs_flush(struct radeon_winsys_cs *rcs, unsigned flags, ui
     struct radeon_drm_cs *cs = radeon_drm_cs(rcs);
     struct radeon_cs_context *tmp;
 
+    switch (cs->base.ring_type) {
+    case RING_DMA:
+           /* pad DMA ring to 8 DWs */
+           if (cs->ws->info.chip_class <= SI) {
+                   while (rcs->cdw & 7)
+                           OUT_CS(&cs->base, 0xf0000000); /* NOP packet */
+           } else {
+                   while (rcs->cdw & 7)
+                           OUT_CS(&cs->base, 0x00000000); /* NOP packet */
+           }
+           break;
+    case RING_GFX:
+           /* pad DMA ring to 8 DWs to meet CP fetch alignment requirements
+            * r6xx, requires at least 4 dw alignment to avoid a hw bug.
+            */
+            if (flags & RADEON_FLUSH_COMPUTE) {
+                   if (cs->ws->info.chip_class <= SI) {
+                           while (rcs->cdw & 7)
+                                   OUT_CS(&cs->base, 0x80000000); /* type2 nop packet */
+                   } else {
+                           while (rcs->cdw & 7)
+                                   OUT_CS(&cs->base, 0xffff1000); /* type3 nop packet */
+                   }
+           } else {
+                   while (rcs->cdw & 7)
+                           OUT_CS(&cs->base, 0x80000000); /* type2 nop packet */
+           }
+           break;
+    }
+
     if (rcs->cdw > RADEON_MAX_CMDBUF_DWORDS) {
        fprintf(stderr, "radeon: command stream overflowed\n");
     }