gallium/u_cpu_detect: fix a race condition on initialization
authorMarek Olšák <marek.olsak@amd.com>
Wed, 5 Sep 2018 23:15:56 +0000 (19:15 -0400)
committerMarek Olšák <marek.olsak@amd.com>
Fri, 7 Sep 2018 19:48:31 +0000 (15:48 -0400)
Reviewed-by: Brian Paul <brianp@vmware.com>
src/gallium/auxiliary/util/u_cpu_detect.c

index 14003aa76928cab01aebb5828e3953971b1ef192..93cf58011db3dde1f7f37941f8e394d36bcf4709 100644 (file)
@@ -36,6 +36,7 @@
 
 #include "u_debug.h"
 #include "u_cpu_detect.h"
+#include "c11/threads.h"
 
 #if defined(PIPE_ARCH_PPC)
 #if defined(PIPE_OS_APPLE)
@@ -366,14 +367,9 @@ check_os_arm_support(void)
 }
 #endif /* PIPE_ARCH_ARM */
 
-void
-util_cpu_detect(void)
+static void
+util_cpu_detect_once(void)
 {
-   static boolean util_cpu_detect_initialized = FALSE;
-
-   if(util_cpu_detect_initialized)
-      return;
-
    memset(&util_cpu_caps, 0, sizeof util_cpu_caps);
 
    /* Count the number of CPUs in system */
@@ -561,6 +557,12 @@ util_cpu_detect(void)
       debug_printf("util_cpu_caps.has_avx512vbmi = %u\n", util_cpu_caps.has_avx512vbmi);
    }
 #endif
+}
+
+static once_flag cpu_once_flag = ONCE_FLAG_INIT;
 
-   util_cpu_detect_initialized = TRUE;
+void
+util_cpu_detect(void)
+{
+   call_once(&cpu_once_flag, util_cpu_detect_once);
 }