re PR libstdc++/64239 (regex_iterator::operator= should copy match_results::position)
authorTim Shen <timshen@google.com>
Fri, 9 Jan 2015 03:58:59 +0000 (03:58 +0000)
committerTim Shen <timshen@gcc.gnu.org>
Fri, 9 Jan 2015 03:58:59 +0000 (03:58 +0000)
PR libstdc++/64239
* include/bits/regex.h (match_results<>::swap): Use std::swap
instead of swap.
* include/bits/regex_compiler.tcc (_Compiler<>::_M_quantifier):
Likewise.
* testsuite/28_regex/match_results/swap.cc: New testcase.

From-SVN: r219373

libstdc++-v3/ChangeLog
libstdc++-v3/include/bits/regex.h
libstdc++-v3/include/bits/regex_compiler.tcc
libstdc++-v3/testsuite/28_regex/match_results/swap.cc [new file with mode: 0644]

index 85b08fa4bd9edc5567de78eebf0403ffb85bab6c..50c74af9a5dafbb03d5a8ce33df2e645fa9809ce 100644 (file)
@@ -1,3 +1,12 @@
+2015-01-09  Tim Shen  <timshen@google.com>
+
+       PR libstdc++/64239
+       * include/bits/regex.h (match_results<>::swap): Use std::swap
+       instead of swap.
+       * include/bits/regex_compiler.tcc (_Compiler<>::_M_quantifier):
+       Likewise.
+       * testsuite/28_regex/match_results/swap.cc: New testcase.
+
 2015-01-08  Jonathan Wakely  <jwakely@redhat.com>
 
        PR libstdc++/60132
index 9b7ed8c71e2e7129c49786859ebbee1e53bf25a2..52c23849a57ebb7942e50d6f978bbc0988b11b5d 100644 (file)
@@ -1863,6 +1863,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11
       void
       swap(match_results& __that)
       {
+       using std::swap;
        _Base_type::swap(__that);
        swap(_M_begin, __that._M_begin);
       }
index 57bafa34d0f236b8b56143a0112ee73d73294ee0..33d7118e024cfc51203876b9528a5dcee436a254 100644 (file)
@@ -276,7 +276,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
                {
                  auto& __tmp = (*_M_nfa)[__stack.top()];
                  __stack.pop();
-                 swap(__tmp._M_next, __tmp._M_alt);
+                 std::swap(__tmp._M_next, __tmp._M_alt);
                }
            }
          _M_stack.push(__e);
diff --git a/libstdc++-v3/testsuite/28_regex/match_results/swap.cc b/libstdc++-v3/testsuite/28_regex/match_results/swap.cc
new file mode 100644 (file)
index 0000000..18248c1
--- /dev/null
@@ -0,0 +1,43 @@
+// { dg-options "-std=gnu++11" }
+
+//
+// Copyright (C) 2015 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+//
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <regex>
+#include <testsuite_hooks.h>
+
+void
+test01()
+{
+  bool test __attribute__((unused)) = true;
+
+  std::cmatch m;
+  std::regex_match("a", m, std::regex("a"));
+  std::cmatch mm1 = m, mm2;
+  mm1.swap(mm2);
+  VERIFY(m == mm2);
+  std::swap(mm1, mm2);
+  VERIFY(m == mm1);
+}
+
+int
+main()
+{
+  test01();
+  return 0;
+}