re PR lto/85583 (lto1: internal compiler error: in lto_balanced_map, at lto/lto-parti...

	PR lto/85583
	* lto-partition.c (account_reference_p): Do not account
	references from aliases; do not account refernces from
	external initializers.

From-SVN: r260266

diff --git a/gcc/lto/ChangeLog b/gcc/lto/ChangeLog
index 77e5915b1632f3e28dda1fc1fe4247c074089901..cd976fa66bb1b623d0825f8a67527aa1311b9ba8 100644 (file)
--- a/gcc/lto/ChangeLog
+++ b/gcc/lto/ChangeLog
@@ -1,3 +1,10 @@
+2018-05-18  Jan Hubicka  <jh@suse.cz>
+
+       PR lto/85583
+       * lto-partition.c (account_reference_p): Do not account
+       references from aliases; do not account refernces from
+       external initializers.
+
 2018-04-30  Jan Hubicka  <jh@suse.cz>
 
        * lto.c (cmp_partitions_size): Remove.

diff --git a/gcc/lto/lto-partition.c b/gcc/lto/lto-partition.c
index 637e5e24b980e4f0ac434e6517982b39f32a56aa..fd796e12a2dc7a660e8d5a1e3c1542e8a05d3752 100644 (file)
--- a/gcc/lto/lto-partition.c
+++ b/gcc/lto/lto-partition.c
@@ -439,12 +439,27 @@ account_reference_p (symtab_node *n1, symtab_node *n2)
 {
   if (cgraph_node *cnode = dyn_cast <cgraph_node *> (n1))
     n1 = cnode;
+  /* Do not account references from aliases - they are never split across
+     partitions.  */
+  if (n1->alias)
+    return false;
   /* Do not account recursion - the code below will handle it incorrectly
-     otherwise.  Also do not account references to external symbols.
-     They will never become local.  */
+     otherwise.  Do not account references to external symbols: they will
+     never become local.  Finally do not account references to duplicated
+     symbols: they will be always local.  */
   if (n1 == n2 
-      || DECL_EXTERNAL (n2->decl)
-      || !n2->definition)
+      || !n2->definition
+      || n2->get_partitioning_class () != SYMBOL_PARTITION)
+    return false;
+  /* If referring node is external symbol do not account it to boundary
+     cost. Those are added into units only to enable possible constant
+     folding and devirtulization.
+
+     Here we do not know if it will ever be added to some partition
+     (this is decided by compute_ltrans_boundary) and second it is not
+     that likely that constant folding will actually use the reference.  */
+  if (contained_in_symbol (n1)
+       ->get_partitioning_class () == SYMBOL_EXTERNAL)
     return false;
   return true;
 }