Lint.

* symfile.c (add_symbol_file_command):  Initialize mapped/readnow.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a25d9d3800a3f9376fb9bf8633fc097454672c05..cebeb96a4373b740917204082eb8043cd6e302d6 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+Thu Apr  2 00:55:56 1992  John Gilmore  (gnu at cygnus.com)
+
+       * c-exp.y, coffread.c, command.c, command.h, copying.awk,
+       dbxread.c, gdbtypes.c, infcmd.c, inferior.h, infrun.c,
+       m2-exp.y, printcmd.c, remote.c, solib.c, source.c, stack.c,
+       symtab.c, tm-sun4os4.h, tm-sun4os5.h, values.c:  Lint.
+       * symfile.c (add_symbol_file_command):  Initialize mapped/readnow.
+
 Wed Apr  1 11:39:52 1992  Fred Fish  (fnf@cygnus.com)
 
        * breakpoint.h (bpdisp, bptype):  Remove trailing comma.

diff --git a/gdb/c-exp.y b/gdb/c-exp.y
index 7d197b9332dfeebee111bd0f6877c8f1772be341..b3bf309fbeb0789d1f09955c944588d444a11398 100644 (file)
--- a/gdb/c-exp.y
+++ b/gdb/c-exp.y
@@ -38,6 +38,9 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "parser-defs.h"
 #include "value.h"
 #include "language.h"
+#include "bfd.h"
+#include "symfile.h"
+#include "objfiles.h"
 
 /* Ensure that if the generated parser contains any calls to malloc/realloc,
    that they get mapped to xmalloc/xrealloc. */

diff --git a/gdb/command.c b/gdb/command.c
index f5e0cec2d9a836a016727c45f5d28570012bd894..3d910107dcf33a6b90cecbb08f2e7f36971adcb5 100644 (file)
--- a/gdb/command.c
+++ b/gdb/command.c
@@ -45,6 +45,9 @@ parse_binary_operation PARAMS ((char *));
 static void
 print_doc_line PARAMS ((FILE *, char *));
 
+extern void
+not_just_help_class_command PARAMS ((char *, int));
+
 /* Add element named NAME to command list *LIST.
    FUN should be the function to execute the command;
    it will get a character string as argument, with leading
@@ -186,10 +189,9 @@ add_abbrev_prefix_cmd (name, class, fun, doc, prefixlist, prefixname,
 
 /* ARGSUSED */
 void
-not_just_help_class_command (args, from_tty, c)
+not_just_help_class_command (args, from_tty)
      char *args;
      int from_tty;
-     struct cmd_list_element *c;
 {
 }
 

diff --git a/gdb/dbxread.c b/gdb/dbxread.c
index 999e0f7715fa40b87d097985f19499bd0c6f9991..a69f39ea80ca4f1ad375e7c52e4d2bc77f5e3fd4 100644 (file)
--- a/gdb/dbxread.c
+++ b/gdb/dbxread.c
@@ -53,6 +53,7 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "command.h"
 #include "target.h"
 #include "gdbcore.h"           /* for bfd stuff */
+#include "libbfd.h"            /* FIXME Secret internal BFD stuff (bfd_read) */
 #include "libaout.h"           /* FIXME Secret internal BFD stuff for a.out */
 #include "symfile.h"
 #include "objfiles.h"
@@ -260,13 +261,13 @@ free_header_files ()
        {
          free (header_files[i].name);
        }
-      free (header_files);
+      free ((PTR)header_files);
       header_files = NULL;
       n_header_files = 0;
     }
   if (this_object_header_files)
     {
-      free (this_object_header_files);
+      free ((PTR)this_object_header_files);
       this_object_header_files = NULL;
     }
   n_allocated_header_files = 0;
@@ -475,8 +476,8 @@ dbx_symfile_read (objfile, addr, mainline)
    file, e.g. a shared library).  */
 
 static void
-dbx_new_init (objfile)
-     struct objfile *objfile;
+dbx_new_init (ignore)
+     struct objfile *ignore;
 {
   buildsym_new_init ();
   init_header_files ();
@@ -506,7 +507,7 @@ dbx_symfile_init (objfile)
   unsigned char size_temp[4];
 
   /* Allocate struct to keep track of the symfile */
-  DBX_SYMFILE_INFO (objfile) = (struct dbx_symfile_info *)
+  objfile->sym_private = (PTR)
     xmmalloc (objfile -> md, sizeof (struct dbx_symfile_info));
 
   /* FIXME POKING INSIDE BFD DATA STRUCTURES */
@@ -535,7 +536,7 @@ dbx_symfile_init (objfile)
   if (val < 0)
     perror_with_name (name);
 
-  val = bfd_read (size_temp, sizeof (long), 1, sym_bfd);
+  val = bfd_read ((PTR)size_temp, sizeof (long), 1, sym_bfd);
   if (val < 0)
     perror_with_name (name);
 
@@ -572,9 +573,9 @@ static void
 dbx_symfile_finish (objfile)
      struct objfile *objfile;
 {
-  if (DBX_SYMFILE_INFO (objfile) != NULL)
+  if (objfile->sym_private != NULL)
     {
-      mfree (objfile -> md, DBX_SYMFILE_INFO (objfile));
+      mfree (objfile -> md, objfile->sym_private);
     }
   free_header_files ();
 }
@@ -602,7 +603,7 @@ static void
 fill_symbuf (sym_bfd)
      bfd *sym_bfd;
 {
-  int nbytes = bfd_read (symbuf, sizeof (symbuf), 1, sym_bfd);
+  int nbytes = bfd_read ((PTR)symbuf, sizeof (symbuf), 1, sym_bfd);
   if (nbytes < 0)
     perror_with_name (bfd_get_filename (sym_bfd));
   else if (nbytes == 0)
@@ -649,9 +650,9 @@ init_psymbol_list (objfile)
 {
   /* Free any previously allocated psymbol lists.  */
   if (objfile -> global_psymbols.list)
-    mfree (objfile -> md, objfile -> global_psymbols.list);
+    mfree (objfile -> md, (PTR)objfile -> global_psymbols.list);
   if (objfile -> static_psymbols.list)
-    mfree (objfile -> md, objfile -> static_psymbols.list);
+    mfree (objfile -> md, (PTR)objfile -> static_psymbols.list);
 
   /* Current best guess is that there are approximately a twentieth
      of the total symbols (in a debugging file) are global or static
@@ -724,7 +725,7 @@ static void
 free_bincl_list (objfile)
      struct objfile *objfile;
 {
-  mfree (objfile -> md, bincl_list);
+  mfree (objfile -> md, (PTR)bincl_list);
   bincls_allocated = 0;
 }
 
@@ -741,7 +742,7 @@ read_dbx_symtab (addr, objfile, text_addr, text_size)
      CORE_ADDR text_addr;
      int text_size;
 {
-  register struct internal_nlist *bufp;
+  register struct internal_nlist *bufp = 0;    /* =0 avoids gcc -Wall glitch */
   register char *namestring;
   int nsl;
   int past_first_source_file = 0;
@@ -1064,17 +1065,14 @@ psymtab_to_symtab_1 (pst, sym_offset)
   pst->readin = 1;
 }
 
-/*
- * Read in all of the symbols for a given psymtab for real.
- * Be verbose about it if the user wants that.
- */
+/* Read in all of the symbols for a given psymtab for real.
+   Be verbose about it if the user wants that.  */
+
 static void
 dbx_psymtab_to_symtab (pst)
      struct partial_symtab *pst;
 {
-  int val;
   bfd *sym_bfd;
-  long st_temp;
 
   if (!pst)
     return;

diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index 788fda8ad60872930d64738dc26ac2c472ecf07f..19dd66a1dd6bc7c1a5f103dba14c9bb71c6c841f 100644 (file)
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -317,6 +317,8 @@ type_name_no_tag (type)
                name += 5;
              }
            break;
+         default:              /* To avoid -Wall warnings */
+           break;
        }
     }
   return (name);

diff --git a/gdb/m2-exp.y b/gdb/m2-exp.y
index 2657eb971e4338de395081c76b3098f23fda0de3..a1bf96faa84fde86606bf73b69df30366b6588eb 100644 (file)
--- a/gdb/m2-exp.y
+++ b/gdb/m2-exp.y
@@ -39,6 +39,9 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "language.h"
 #include "value.h"
 #include "parser-defs.h"
+#include "bfd.h"
+#include "symfile.h"
+#include "objfiles.h"
 
 /* Ensure that if the generated parser contains any calls to malloc/realloc,
    that they get mapped to xmalloc/xrealloc. */

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 3cfe4ea18bb237fedea5b5cda62999b061abe03d..8ef5ed90e2ffcde7b8260ff68f2e4f0f87fe6059 100644 (file)
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -446,7 +446,6 @@ symbol_file_add (name, from_tty, addr, mainline, mapped, readnow)
   struct objfile *objfile;
   struct partial_symtab *psymtab;
   bfd *abfd;
-  int mapped_it;
 
   /* Open a bfd for the file and then check to see if the file has a
      symbol table.  There is a distinction between having no symbol table
@@ -550,7 +549,6 @@ symbol_file_command (args, from_tty)
   char **argv;
   char *name = NULL;
   struct cleanup *cleanups;
-  struct objfile *objfile;
   int mapped = 0;
   int readnow = 0;
 
@@ -603,7 +601,7 @@ symbol_file_command (args, from_tty)
          /* Getting new symbols may change our opinion about what is
             frameless.  */
          reinit_frame_cache ();
-         objfile = symbol_file_add (name, from_tty, (CORE_ADDR)0, 1,
+         (void) symbol_file_add (name, from_tty, (CORE_ADDR)0, 1,
                                     mapped, readnow);
        }
       do_cleanups (cleanups);
@@ -678,7 +676,7 @@ static void
 find_sym_fns (objfile)
      struct objfile *objfile;
 {
-  struct sym_fns *sf, *sf2;
+  struct sym_fns *sf;
 
   for (sf = symtab_fns; sf != NULL; sf = sf -> next)
     {
@@ -715,8 +713,8 @@ add_symbol_file_command (args, from_tty)
   char *name = NULL;
   CORE_ADDR text_addr;
   char *arg;
-  int readnow;
-  int mapped;
+  int readnow = 0;
+  int mapped = 0;
   
   dont_repeat ();
 
@@ -1127,18 +1125,21 @@ int
 free_named_symtabs (name)
      char *name;
 {
-  register struct symtab *s;
-  register struct symtab *prev;
-  register struct partial_symtab *ps;
-  struct blockvector *bv;
-  int blewit = 0;
-
 #if 0
   /* FIXME:  With the new method of each objfile having it's own
      psymtab list, this function needs serious rethinking.  In particular,
      why was it ever necessary to toss psymtabs with specific compilation
      unit filenames, as opposed to all psymtabs from a particular symbol
-     file. */
+     file?  -- fnf
+     Well, the answer is that some systems permit reloading of particular
+     compilation units.  We want to blow away any old info about these
+     compilation units, regardless of which objfiles they arrived in. --gnu.  */
+
+  register struct symtab *s;
+  register struct symtab *prev;
+  register struct partial_symtab *ps;
+  struct blockvector *bv;
+  int blewit = 0;
 
   /* We only wack things if the symbol-reload switch is set.  */
   if (!symbol_reloading)

diff --git a/gdb/tm-sun4os4.h b/gdb/tm-sun4os4.h
index 309720a428e6552859771913287a30453925c680..6fec9218e0c57dff58d15239d2331fcca125f4f5 100644 (file)
--- a/gdb/tm-sun4os4.h
+++ b/gdb/tm-sun4os4.h
@@ -44,4 +44,7 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
    extract the pc (JB_PC) that we will land at.  The pc is copied into ADDR.
    This routine returns true on success */
 
+extern int
+get_longjmp_target PARAMS ((CORE_ADDR *));
+
 #define GET_LONGJMP_TARGET(ADDR) get_longjmp_target(ADDR)

diff --git a/gdb/tm-sun4os5.h b/gdb/tm-sun4os5.h
index e241bbddd72129339a9586abe1796dc3988e5a78..942fb87890f4e729481c1329eab4c78a09fcd796 100644 (file)
--- a/gdb/tm-sun4os5.h
+++ b/gdb/tm-sun4os5.h
@@ -47,6 +47,8 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
    extract the pc (JB_PC) that we will land at.  The pc is copied into ADDR.
    This routine returns true on success */
 
-#define GET_LONGJMP_TARGET(ADDR) get_longjmp_target(ADDR)
+extern int
+get_longjmp_target PARAMS ((CORE_ADDR *));
 
+#define GET_LONGJMP_TARGET(ADDR) get_longjmp_target(ADDR)
 #endif  /* 0 */

diff --git a/gdb/values.c b/gdb/values.c
index 998c42eac847fe4f6283a72e1d23bcfb07e7be46..512cc64c8a075db75b35191c9358138cc40eb64e 100644 (file)
--- a/gdb/values.c
+++ b/gdb/values.c
@@ -26,6 +26,7 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  */
 #include "frame.h"
 #include "command.h"
 #include "gdbcmd.h"
+#include "target.h"
 
 /* Local function prototypes. */
 
@@ -36,7 +37,7 @@ static void
 show_values PARAMS ((char *, int));
 
 static void
-show_convenience PARAMS ((void));
+show_convenience PARAMS ((char *, int));
 
 /* The value-history records all the values printed
    by print commands during this session.  Each chunk
@@ -481,7 +482,9 @@ clear_internalvars ()
 }
 
 static void
-show_convenience ()
+show_convenience (ignore, from_tty)
+     char *ignore;
+     int from_tty;
 {
   register struct internalvar *var;
   int varseen = 0;
@@ -494,10 +497,6 @@ show_convenience ()
 #endif
       if (!varseen)
        {
-#if 0
-         /* Useless noise.  */
-         printf ("Debugger convenience variables:\n\n");
-#endif
          varseen = 1;
        }
       printf_filtered ("$%s = ", var->name);