i965/miptree: Use the tiling from the modifier instead of the BO
authorJason Ekstrand <jason@jlekstrand.net>
Sat, 18 Nov 2017 00:10:54 +0000 (16:10 -0800)
committerJason Ekstrand <jason.ekstrand@intel.com>
Mon, 22 Jan 2018 07:07:18 +0000 (23:07 -0800)
This fixes a bug where we were taking the tiling from the BO regardless
of what the modifier said.  When we got images in from Vulkan where it
doesn't set the tiling on the BO, we would treat them as linear even
though the modifier expressly said to treat it as Y-tiled.

Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Cc: mesa-stable@lists.freedesktop.org
src/mesa/drivers/dri/i965/intel_mipmap_tree.c

index fd506163e9573db7628818f3922101d103ae3fa6..e129d5eb9fbf0413fded380586335d6fd091038b 100644 (file)
@@ -990,7 +990,11 @@ intel_miptree_create_for_dri_image(struct brw_context *brw,
    uint32_t bo_tiling, bo_swizzle;
    brw_bo_get_tiling(image->bo, &bo_tiling, &bo_swizzle);
 
-   const enum isl_tiling tiling = isl_tiling_from_i915_tiling(bo_tiling);
+   const struct isl_drm_modifier_info *mod_info =
+      isl_drm_modifier_get_info(image->modifier);
+
+   const enum isl_tiling tiling =
+      mod_info ? mod_info->tiling : isl_tiling_from_i915_tiling(bo_tiling);
 
    if (image->planar_format && image->planar_format->nplanes > 1)
       return miptree_create_for_planar_image(brw, image, target, tiling);
@@ -1014,9 +1018,6 @@ intel_miptree_create_for_dri_image(struct brw_context *brw,
    if (!brw->ctx.TextureFormatSupported[format])
       return NULL;
 
-   const struct isl_drm_modifier_info *mod_info =
-      isl_drm_modifier_get_info(image->modifier);
-
    enum intel_miptree_create_flags mt_create_flags = 0;
 
    /* If this image comes in from a window system, we have different