support/download: svn non-interactive in BR2_SVN
authorSam Voss <sam.voss@rockwellcollins.com>
Fri, 17 Nov 2017 18:50:34 +0000 (12:50 -0600)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Sun, 26 Nov 2017 13:18:57 +0000 (14:18 +0100)
Instead of overriding the _svn command and injecting --non-interactive,
change the default value of BR2_SVN to include this flag so the end user
can choose not to use the flag.

This change helps users behind corporate system rules which may not
allow them to locally cache credentials and require interactive mode.

Signed-off-by: Sam Voss <sam.voss@rockwellcollins.com>
[Originally implemented by]
CC: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Config.in
support/download/svn

index 8920b727ce8e5e34875bd28f74d86b67cd7b94d5..75e56048317f86fdb7a1e7e29da7c0976f635b45 100644 (file)
--- a/Config.in
+++ b/Config.in
@@ -106,7 +106,7 @@ config BR2_WGET
 
 config BR2_SVN
        string "Subversion (svn) command"
-       default "svn"
+       default "svn --non-interactive"
 
 config BR2_BZR
        string "Bazaar (bzr) command"
index 9f27d71f866393560b250abd7238ae6bad105f3d..77abf3d02dad6c54313f4583bcb0d4fab0bfe0ce 100755 (executable)
@@ -33,6 +33,6 @@ _svn() {
     eval ${SVN} "${@}"
 }
 
-_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
+_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
 
 tar czf "${output}" "${basename}"