i386-tdep.c (i386_gdbarch_init): Add comments.

gdb/ChangeLog:

	* i386-tdep.c (i386_gdbarch_init): Add comments.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dd9f8cb383ce82e27443ad60047a9941e7d5cfd8..f4f6fd5148748e55059feaabcfd8b567831a22bd 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2016-11-07  Doug Evans  <dje@google.com>
+
+       * i386-tdep.c (i386_gdbarch_init): Add comments.
+
 2016-11-07  Doug Evans  <dje@google.com>
 
        * python/py-unwind.c (unwind_infopy_str): Fix use of VEC_iterate.

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index a67eca00164192321d9b93ff21fb581afd4c215d..22fb54cea03b915e72086ab787bb0976b3f6d95a 100644 (file)
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -8316,6 +8316,8 @@ i386_validate_tdesc_p (struct gdbarch_tdep *tdep,
 }
 
 \f
+/* Note: This is called for both i386 and amd64.  */
+
 static struct gdbarch *
 i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 {
@@ -8333,7 +8335,7 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   if (arches != NULL)
     return arches->gdbarch;
 
-  /* Allocate space for the new architecture.  */
+  /* Allocate space for the new architecture.  Assume i386 for now.  */
   tdep = XCNEW (struct gdbarch_tdep);
   gdbarch = gdbarch_alloc (&info, tdep);
 
@@ -8560,7 +8562,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
   set_gdbarch_insn_is_ret (gdbarch, i386_insn_is_ret);
   set_gdbarch_insn_is_jump (gdbarch, i386_insn_is_jump);
 
-  /* Hook in ABI-specific overrides, if they have been registered.  */
+  /* Hook in ABI-specific overrides, if they have been registered.
+     Note: If INFO specifies a 64 bit arch, this is where we turn
+     a 32-bit i386 into a 64-bit amd64.  */
   info.tdep_info = tdesc_data;
   gdbarch_init_osabi (info, gdbarch);