re PR c/19999 (-Wfloat-equal does not warn for complex numbers)

gcc/:
PR c/19999
* c-typeck.c (build_binary_op): Warn about floating point
comparisons if FLOAT_TYPE_P, not only for REAL_TYPE.

gcc/cp/:
* typeck.c (build_binary_op): Warn about floating point
comparisons if FLOAT_TYPE_P, not only for REAL_TYPE.

gcc/testsuite/:
* gcc.dg/Wfloat-equal-1.c: New.
* g++.dg/warn/Wfloat-equal-1.C: New.

From-SVN: r132540

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 93b1e073f3d927a26277283c371ec567af74952d..a7253f95ff1bceceec16b45df5e8259b9faabaff 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-02-22  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
+
+       PR c/19999
+       * c-typeck.c (build_binary_op): Warn about floating point
+       comparisons if FLOAT_TYPE_P, not only for REAL_TYPE.
+
 2008-02-21  Janis Johnson  <janis187@us.ibm.com>
 
        PR target/34526

diff --git a/gcc/c-typeck.c b/gcc/c-typeck.c
index 60b0b02fc042a38a88c21238a8a35dd64c31566d..55b4b23a8321072d7796c003a0c4d52cecded76d 100644 (file)
--- a/gcc/c-typeck.c
+++ b/gcc/c-typeck.c
@@ -8138,7 +8138,7 @@ build_binary_op (enum tree_code code, tree orig_op0, tree orig_op1,
 
     case EQ_EXPR:
     case NE_EXPR:
-      if (code0 == REAL_TYPE || code1 == REAL_TYPE)
+      if (FLOAT_TYPE_P (type0) || FLOAT_TYPE_P (type1))
        warning (OPT_Wfloat_equal,
                 "comparing floating point with == or != is unsafe");
       /* Result of comparison is always int,

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 81a243a1354afb62d05696c2e5f74bdeb7f2db53..b300db04bff071c0b65aa0b3591d854095ecb244 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2008-02-22  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
+
+       PR c/19999
+       * typeck.c (build_binary_op): Warn about floating point
+       comparisons if FLOAT_TYPE_P, not only for REAL_TYPE.
+
 2008-02-19  Jason Merrill  <jason@redhat.com>
 
        PR c++/34950

diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index 9764ed369a2d68b4260d64b43c89ceb123cbd02c..eef6914da567cc434de48bedb76acf20d4729b73 100644 (file)
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -3359,7 +3359,7 @@ build_binary_op (enum tree_code code, tree orig_op0, tree orig_op1,
 
     case EQ_EXPR:
     case NE_EXPR:
-      if (code0 == REAL_TYPE || code1 == REAL_TYPE)
+      if (FLOAT_TYPE_P (type0) || FLOAT_TYPE_P (type1))
        warning (OPT_Wfloat_equal,
                 "comparing floating point with == or != is unsafe");
       if ((TREE_CODE (orig_op0) == STRING_CST && !integer_zerop (op1))

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 259bfbe1236e39a6e4b46fe0e34b59f1fcbf29b2..493effcce42b6870a89c63d85a258f11bf091485 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2008-02-22  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
+
+       PR c/19999
+       * gcc.dg/Wfloat-equal-1.c: New.
+       * g++.dg/warn/Wfloat-equal-1.C: New.
+
 2008-02-21  Michael Matz  <matz@suse.de>
 
        PR target/35264

diff --git a/gcc/testsuite/g++.dg/warn/Wfloat-equal-1.C b/gcc/testsuite/g++.dg/warn/Wfloat-equal-1.C
new file mode 100644 (file)
index 0000000..36b3fa5
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/Wfloat-equal-1.C
@@ -0,0 +1,10 @@
+/* PR c/19999 */
+/* { dg-do compile } */
+/* { dg-options "-Wfloat-equal" } */
+
+double a, b;
+_Complex double c, d;
+int f(void) { return a == b; } /* { dg-warning "comparing floating point" } */
+int g(void) { return c == d; } /* { dg-warning "comparing floating point" } */
+int h(void) { return a != b; } /* { dg-warning "comparing floating point" } */
+int i(void) { return c != d; } /* { dg-warning "comparing floating point" } */

diff --git a/gcc/testsuite/gcc.dg/Wfloat-equal-1.c b/gcc/testsuite/gcc.dg/Wfloat-equal-1.c
new file mode 100644 (file)
index 0000000..36b3fa5
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wfloat-equal-1.c
@@ -0,0 +1,10 @@
+/* PR c/19999 */
+/* { dg-do compile } */
+/* { dg-options "-Wfloat-equal" } */
+
+double a, b;
+_Complex double c, d;
+int f(void) { return a == b; } /* { dg-warning "comparing floating point" } */
+int g(void) { return c == d; } /* { dg-warning "comparing floating point" } */
+int h(void) { return a != b; } /* { dg-warning "comparing floating point" } */
+int i(void) { return c != d; } /* { dg-warning "comparing floating point" } */