PR binutils/16024

	* objdump.c (usage): Mark as a no-return function.
	(main): Add comment explaining why a break statement is not
	needed.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 2bebf999999bb7ab5ab8b20853d8abe882da4187..48d3f0ba251156f34f9d908c65437a64924cdb42 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,5 +1,10 @@
 2013-10-09  Nick Clifton  <nickc@redhat.com>
 
+       PR binutils/16024
+       * objdump.c (usage): Mark as a no-return function.
+       (main): Add comment explaining why a break statement is not
+       needed.
+
        * dwarf.c (add64): New function.
        (read_and_display_attr_value): Add CU offset in to the value
        displayed for a DW_AT_ref8 attribute.

diff --git a/binutils/objdump.c b/binutils/objdump.c
index 89efc155fbba8d65182773a6f7b816ab9b8d8f63..37962cb157898d8f8f50a6d86ab159d6b2065308 100644 (file)
--- a/binutils/objdump.c
+++ b/binutils/objdump.c
@@ -1,7 +1,5 @@
 /* objdump.c -- dump information about an object file.
-   Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
-   2012, 2013 Free Software Foundation, Inc.
+   Copyright 1990-2013 Free Software Foundation, Inc.
 
    This file is part of GNU Binutils.
 
@@ -193,6 +191,7 @@ static const struct objdump_private_desc * const objdump_private_vectors[] =
     NULL
   };
 \f
+static void usage (FILE *, int) ATTRIBUTE_NORETURN;
 static void
 usage (FILE *stream, int status)
 {
@@ -3657,15 +3656,15 @@ main (int argc, char **argv)
          dump_section_headers = TRUE;
          seenflag = TRUE;
          break;
-       case 'H':
-         usage (stdout, 0);
-         seenflag = TRUE;
        case 'v':
        case 'V':
          show_version = TRUE;
          seenflag = TRUE;
          break;
 
+       case 'H':
+         usage (stdout, 0);
+         /* No need to set seenflag or to break - usage() does not return.  */
        default:
          usage (stderr, 1);
        }