re PR tree-optimization/14197 (Wrong code for bcopy/memmove (string-asm-2.c))

	PR tree-optimization/14197
	* builtins.c: Include "tree-gimple.h"
	(readonly_data_expr): Use get_base_address.  Make sure to call
	decl_readonly_section only on trees it can handle.
	* tree-gimple.c (get_base_address): Accept STRING_CST and
	CONSTRUCTOR expressions.
	* Makefile.in: Update dependencies.

From-SVN: r82209

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7d5ddfbc8fc68e62bca16ccd1a55b5d9d5eef064..ced1a4d5499c2dffa72abd36c4061c0f631ec618 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,13 @@
+2004-05-24  Ulrich Weigand  <uweigand@de.ibm.com>
+
+       PR tree-optimization/14197
+       * builtins.c: Include "tree-gimple.h"
+       (readonly_data_expr): Use get_base_address.  Make sure to call 
+       decl_readonly_section only on trees it can handle.
+       * tree-gimple.c (get_base_address): Accept STRING_CST and
+       CONSTRUCTOR expressions.
+       * Makefile.in: Update dependencies.
+
 2004-05-23  Paolo Bonzini  <bonzini@gnu.org>
 
        Move libcpp to the toplevel.

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index c39920d04da279c00e7343229b3a72724425a9f5..641ce2f6068a35408076e5d20ab0bdb2c8183fdf 100644 (file)
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1766,8 +1766,8 @@ dojump.o : dojump.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(TREE_
    flags.h function.h $(EXPR_H) $(OPTABS_H) $(INSN_ATTR_H) insn-config.h \
    langhooks.h $(GGC_H) gt-dojump.h
 builtins.o : builtins.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(TREE_H)\
-   flags.h $(TARGET_H) function.h $(REGS_H) $(EXPR_H) $(OPTABS_H) insn-config.h \
-   $(RECOG_H) output.h typeclass.h hard-reg-set.h toplev.h hard-reg-set.h \
+   $(TREE_GIMPLE_H) flags.h $(TARGET_H) function.h $(REGS_H) $(EXPR_H) $(OPTABS_H) \
+   insn-config.h $(RECOG_H) output.h typeclass.h hard-reg-set.h toplev.h hard-reg-set.h \
    except.h $(TM_P_H) $(PREDICT_H) libfuncs.h real.h langhooks.h
 calls.o : calls.c $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) $(RTL_H) $(TREE_H) flags.h \
    $(EXPR_H) $(OPTABS_H) langhooks.h $(TARGET_H) \

diff --git a/gcc/builtins.c b/gcc/builtins.c
index 2457d66142110d05b5bc5a4006b96a776a3c856b..d56136a88047fbb4d1368b915cc6af315eff764e 100644 (file)
--- a/gcc/builtins.c
+++ b/gcc/builtins.c
@@ -27,6 +27,7 @@ Software Foundation, 59 Temple Place - Suite 330, Boston, MA
 #include "real.h"
 #include "rtl.h"
 #include "tree.h"
+#include "tree-gimple.h"
 #include "flags.h"
 #include "regs.h"
 #include "hard-reg-set.h"
@@ -7925,8 +7926,20 @@ readonly_data_expr (tree exp)
 {
   STRIP_NOPS (exp);
 
-  if (TREE_CODE (exp) == ADDR_EXPR)
-    return decl_readonly_section (TREE_OPERAND (exp, 0), 0);
+  if (TREE_CODE (exp) != ADDR_EXPR)
+    return false;
+
+  exp = get_base_address (TREE_OPERAND (exp, 0));
+  if (!exp)
+    return false;
+
+  /* Make sure we call decl_readonly_section only for trees it
+     can handle (since it returns true for everything it doesn't
+     understand).  */
+  if (TREE_CODE (exp) == STRING_CST 
+      || TREE_CODE (exp) == CONSTRUCTOR
+      || (TREE_CODE (exp) == VAR_DECL && TREE_STATIC (exp)))
+    return decl_readonly_section (exp, 0);
   else
     return false;
 }

diff --git a/gcc/tree-gimple.c b/gcc/tree-gimple.c
index dbe2966e1e95f306f64280b313752d178f5302f6..18bc2f8afa36aa57eb3a8be8688df9d8e3343554 100644 (file)
--- a/gcc/tree-gimple.c
+++ b/gcc/tree-gimple.c
@@ -574,6 +574,8 @@ get_base_address (tree t)
   do
     {
       if (SSA_VAR_P (t)
+         || TREE_CODE (t) == STRING_CST
+         || TREE_CODE (t) == CONSTRUCTOR
          || TREE_CODE (t) == INDIRECT_REF)
        return t;