mesa/copyimage: report INVALID_VALUE for missing cube face
authorDave Airlie <airlied@redhat.com>
Thu, 2 Jun 2016 04:13:18 +0000 (14:13 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 2 Jun 2016 20:08:44 +0000 (06:08 +1000)
The specs says INVALID_VALUE for exceeding dimensions,
which is really what is happening here.

This fixes:
GL45-CTS.copy_image.non_existent_mipmap

Cc: "11.2 12.0" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Antia Puentes <apuentes@igalia.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
src/mesa/main/copyimage.c

index 6aa6bcb973af217ce868cd2fb2235d247c490311..7e5df61682a9fec70c136e9ca98571c34458fafa 100644 (file)
@@ -180,7 +180,7 @@ prepare_target(struct gl_context *ctx, GLuint name, GLenum target,
          for (i = 0; i < depth; i++) {
             if (!texObj->Image[z+i][level]) {
                /* missing cube face */
-               _mesa_error(ctx, GL_INVALID_OPERATION,
+               _mesa_error(ctx, GL_INVALID_VALUE,
                            "glCopyImageSubData(missing cube face)");
                return false;
             }