projects / buildroot.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: e4f7ec4)
package/valgrind: hide comment when arch is not supported
authorYann E. MORIN <yann.morin.1998@free.fr>
Thu, 10 Aug 2017 21:51:11 +0000 (23:51 +0200)
committerArnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Fri, 11 Aug 2017 10:47:35 +0000 (12:47 +0200)
Currently, the comment that "valgrind needs shared libs" is not hidden
when the architecture dependencies are not met, which can confuse some
users (as recently seen on IRC).

Fix that by introducing the traditional _ARCH_SUPPORTS option, and have
the comment and the symbol depend on that.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Brandon Maier <brandon.maier@rockwellcollins.com>
Cc: Jérôme Pouiller <jezz@sysmic.org>
Cc: Peter Seiderer <ps.report@gmx.net>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed--by: Pedro Ribeiro <pedrib@gmail.com>
Tested-by: Pedro Ribeiro <pedrib@gmail.com>
[Arnout: put _ARCH_SUPPORTS at the top of the file]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
package/valgrind/Config.in patch | blob | history

diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index 40e219d95af23449467ae1fd859893e207f65976..75b779d214351a259a2ae0689da6f5d4199ecdcb 100644 (file)
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,14 +1,19 @@
+config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
+       bool
+       default y if BR2_ARM_CPU_ARMV7A
+       default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+       default y if BR2_i386 || BR2_x86_64
+       default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
+       depends on !BR2_MIPS_SOFT_FLOAT
+
 comment "valgrind needs a toolchain w/ dynamic library"
+       depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
        depends on BR2_STATIC_LIBS
 
 config BR2_PACKAGE_VALGRIND
        bool "valgrind"
-       depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \
-                  BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
-                  BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
-                  BR2_x86_64
+       depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS
        depends on !BR2_STATIC_LIBS
-       depends on !BR2_MIPS_SOFT_FLOAT
        help
          Tool for debugging and profiling Linux programs.