linux-record: Fix bad fall-through for pipe/pipe2

This patch added handling for some syscalls to linux-record.c:

  https://sourceware.org/ml/gdb-patches/2015-10/msg00452.html

But for both `pipe' and `pipe2' the patch lacks a statement after an
`if', such that the following `break' is interpreted as the `if'-body
instead.

This adds the missing (return-) statements for the conditionals.

gdb/ChangeLog:

	* linux-record.c (record_linux_system_call): Add missing return
	statements to handling of pipe and pipe2 syscalls.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index a9952cb765b21103ef0997c1a63f9e334384a84a..bc1b2f5e81f76da6aea277a4de8b145ae1fb3b21 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
+
+       * linux-record.c (record_linux_system_call): Add missing return
+       statements to handling of pipe and pipe2 syscalls.
+
 2016-03-16  Doug Evans  <dje@google.com>
 
        * xml-tdesc.c (tdesc_start_enum): Fix c++ build.

diff --git a/gdb/linux-record.c b/gdb/linux-record.c
index a40845af9cb72f8ff4e9fa2fbd4ae25680ce2943..2e86936eb3cd5b34162d480ec876c25210993faf 100644 (file)
--- a/gdb/linux-record.c
+++ b/gdb/linux-record.c
@@ -354,6 +354,7 @@ record_linux_system_call (enum gdb_syscall syscall,
       regcache_raw_read_unsigned (regcache, tdep->arg1, &tmpulongest);
       if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
                                         tdep->size_int * 2))
+        return -1;
       break;
 
     case gdb_sys_times:
@@ -2312,6 +2313,7 @@ Do you want to stop the program?"),
       regcache_raw_read_unsigned (regcache, tdep->arg1, &tmpulongest);
       if (record_full_arch_list_add_mem ((CORE_ADDR) tmpulongest,
                                         tdep->size_int * 2))
+        return -1;
       break;
 
     case gdb_sys_inotify_init1: