Refactor whole-variable assigment checking into member function

diff --git a/ir.h b/ir.h
index 2e6a19432149094e515abe49bf3e49d2d2d211bd..306ec8c162b109907cc830e7ebed4a82c41481b1 100644 (file)
--- a/ir.h
+++ b/ir.h
@@ -95,6 +95,21 @@ public:
       return NULL;
    }
 
+
+   /**
+    * If an r-value is a reference to a whole variable, get that variable
+    *
+    * \return
+    * Pointer to a variable that is completely dereferenced by the r-value.  If
+    * the r-value is not a dereference or the dereference does not access the
+    * entire variable (i.e., it's just one array element, struct field), \c NULL
+    * is returned.
+    */
+   virtual ir_variable *whole_variable_referenced()
+   {
+      return NULL;
+   }
+
 protected:
    ir_rvalue()
    {
@@ -827,6 +842,17 @@ public:
       return this->var;
    }
 
+   virtual ir_variable *whole_variable_referenced()
+   {
+      /* ir_dereference_variable objects always dereference the entire
+       * variable.  However, if this dereference is dereferenced by anything
+       * else, the complete deferefernce chain is not a whole-variable
+       * dereference.  This method should only be called on the top most
+       * ir_rvalue in a dereference chain.
+       */
+      return this->var;
+   }
+
    virtual void accept(ir_visitor *v)
    {
       v->visit(this);

diff --git a/ir_copy_propagation.cpp b/ir_copy_propagation.cpp
index e395fa9723b4b30a5bc8df44da49ece71b926742..82172d29b65ceb6ec06d29b240aaf35d9d974caf 100644 (file)
--- a/ir_copy_propagation.cpp
+++ b/ir_copy_propagation.cpp
@@ -267,18 +267,13 @@ add_copy(ir_assignment *ir, exec_list *acp)
         return;
    }
 
-   ir_dereference *lhs_deref = ir->lhs->as_dereference();
-   if (!lhs_deref || lhs_deref->mode != ir_dereference::ir_reference_variable)
-      return;
-   ir_variable *lhs_var = lhs_deref->variable_referenced();
-
-   ir_dereference *rhs_deref = ir->rhs->as_dereference();
-   if (!rhs_deref || rhs_deref->mode != ir_dereference::ir_reference_variable)
-      return;
-   ir_variable *rhs_var = rhs_deref->variable_referenced();
-
-   entry = new acp_entry(lhs_var, rhs_var);
-   acp->push_tail(entry);
+   ir_variable *lhs_var = ir->lhs->whole_variable_referenced();
+   ir_variable *rhs_var = ir->rhs->whole_variable_referenced();
+
+   if ((lhs_var != NULL) && (rhs_var != NULL)) {
+      entry = new acp_entry(lhs_var, rhs_var);
+      acp->push_tail(entry);
+   }
 }
 
 static void

diff --git a/ir_dead_code_local.cpp b/ir_dead_code_local.cpp
index 9ac209df576e9880bb006249b175c9fe94f43714..e83b300390bb60054545820c0390cdd7f6f2b973 100644 (file)
--- a/ir_dead_code_local.cpp
+++ b/ir_dead_code_local.cpp
@@ -139,10 +139,7 @@ process_assignment(ir_assignment *ir, exec_list *assignments)
    }
 
    /* Now, check if we did a whole-variable assignment. */
-   ir_dereference *lhs_deref = ir->lhs->as_dereference();
-   if (always_assign &&
-       lhs_deref &&
-       lhs_deref->mode == ir_dereference::ir_reference_variable) {
+   if (always_assign && (ir->lhs->whole_variable_referenced() != NULL)) {
       /* We did a whole-variable assignment.  So, any instruction in
        * the assignment list with the same LHS is dead.
        */