re PR c/60819 (dse1 removing not-dead insn (aliasing issue?))

2014-04-14  Richard Biener  <rguenther@suse.de>
	Marc Glisse  <marc.glisse@inria.fr>

	PR c/60819
	c-family/
	* c-common.c (convert_vector_to_pointer_for_subscript): Properly
	apply may-alias the scalar pointer type when applicable.

	* gcc.target/i386/vec-may_alias.c: New testcase.

Co-Authored-By: Marc Glisse <marc.glisse@inria.fr>
From-SVN: r209365

diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index f510bcc66e3c5a17bbdce977a541e0bf7237c5ba..206b47b13699059278787d1e90f77c16097b0103 100644 (file)
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,10 @@
+2014-04-14  Richard Biener  <rguenther@suse.de>
+       Marc Glisse  <marc.glisse@inria.fr>
+
+       PR c/60819
+       * c-common.c (convert_vector_to_pointer_for_subscript): Properly
+       apply may-alias the scalar pointer type when applicable.
+
 2014-04-12  Igor Zamyatin  <igor.zamyatin@intel.com>
 
        PR middle-end/60467

diff --git a/gcc/c-family/c-common.c b/gcc/c-family/c-common.c
index 1d56bc02ec82aff259100c7ba261c00802700312..c0e247b27071b267f7c3b8f52ac5587239132367 100644 (file)
--- a/gcc/c-family/c-common.c
+++ b/gcc/c-family/c-common.c
@@ -11784,8 +11784,21 @@ convert_vector_to_pointer_for_subscript (location_t loc,
 
       c_common_mark_addressable_vec (*vecp);
       type = build_qualified_type (TREE_TYPE (type), TYPE_QUALS (type));
-      type = build_pointer_type (type);
       type1 = build_pointer_type (TREE_TYPE (*vecp));
+      bool ref_all = TYPE_REF_CAN_ALIAS_ALL (type1);
+      if (!ref_all
+         && !DECL_P (*vecp))
+       {
+         /* If the original vector isn't declared may_alias and it
+            isn't a bare vector look if the subscripting would
+            alias the vector we subscript, and if not, force ref-all.  */
+         alias_set_type vecset = get_alias_set (*vecp);
+         alias_set_type sset = get_alias_set (type);
+         if (!alias_sets_must_conflict_p (sset, vecset)
+             && !alias_set_subset_of (sset, vecset))
+           ref_all = true;
+       }
+      type = build_pointer_type_for_mode (type, ptr_mode, ref_all);
       *vecp = build1 (ADDR_EXPR, type1, *vecp);
       *vecp = convert (type, *vecp);
     }

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e944a0e2d9840b76edb5e52f320cdcfb5df1a757..36655885d10bc4dd48afe3582bc0c026c6faaf3a 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2014-04-14  Richard Biener  <rguenther@suse.de>
+       Marc Glisse  <marc.glisse@inria.fr>
+
+       PR c/60819
+       * gcc.target/i386/vec-may_alias.c: New testcase.
+
 2014-04-14  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 
        * lib/target-supports.exp

diff --git a/gcc/testsuite/gcc.target/i386/vec-may_alias.c b/gcc/testsuite/gcc.target/i386/vec-may_alias.c
new file mode 100644 (file)
index 0000000..e970497
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/vec-may_alias.c
@@ -0,0 +1,25 @@
+/* { dg-do run } */
+/* { dg-options "-O2 -w -Wno-abi" } */
+
+typedef int v2si __attribute__ ((vector_size (8)));
+typedef short v4hi __attribute__ ((vector_size (8)));
+typedef short v4hia __attribute__ ((vector_size (8), may_alias));
+
+__attribute__ ((noinline, noclone))
+int f (v2si A, int N)
+{ return ((v4hia)A)[N]; }
+
+__attribute__ ((noinline, noclone))
+int g (v2si A, int N)
+{ return ((v4hi)A)[N]; }
+
+int main()
+{
+  v2si x = { 0, 0 }, y = { 1, 1 };
+  if (f (x, 0) || f (x, 1) || f (x, 2) || f (x, 3))
+    __builtin_abort ();
+  if (g (y, 0) != 1 || g (y, 1) || g (y, 2) != 1 || g (y, 3))
+    __builtin_abort ();
+  return 0;
+}
+