util/disk_cache: Remove unneeded free() on always null string
authorVadym Shovkoplias <vadym.shovkoplias@globallogic.com>
Mon, 4 Dec 2017 09:47:33 +0000 (11:47 +0200)
committerEric Engestrom <eric.engestrom@imgtec.com>
Thu, 7 Dec 2017 11:50:41 +0000 (11:50 +0000)
At this point dc_job->cache_item_metadata.keys always equals
NULL, so call to free() is useless

Fixes: b86ecea3446 ("util/disk_cache: write cache item metadata to disk")
Signed-off-by: Vadym Shovkoplias <vadym.shovkoplias@globallogic.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
src/util/disk_cache.c

index e95406565e4d5e36e475318023c36bf1c5946579..7ebfa8c045c8da128166a1b22d64763d12e664f3 100644 (file)
@@ -811,7 +811,6 @@ create_put_job(struct disk_cache *cache, const cache_key key,
    return dc_job;
 
 fail:
-   free(dc_job->cache_item_metadata.keys);
    free(dc_job);
 
    return NULL;