radv: always dirty some states after executing secondary buffers
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Wed, 11 Oct 2017 14:10:43 +0000 (16:10 +0200)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Mon, 16 Oct 2017 12:09:51 +0000 (14:09 +0200)
The spec requires the number of buffer to be greater than 0.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
src/amd/vulkan/radv_cmd_buffer.c

index b01f1ee7efafa4e8698a7506cdf0e3b72492aecb..64e7e2637b91b4bf631c2e18b0c5be2deb5d39d1 100644 (file)
@@ -2622,6 +2622,8 @@ void radv_CmdExecuteCommands(
 {
        RADV_FROM_HANDLE(radv_cmd_buffer, primary, commandBuffer);
 
+       assert(commandBufferCount > 0);
+
        /* Emit pending flushes on primary prior to executing secondary */
        si_emit_cache_flush(primary);
 
@@ -2671,12 +2673,12 @@ void radv_CmdExecuteCommands(
                primary->state.last_primitive_reset_index = secondary->state.last_primitive_reset_index;
        }
 
-       /* if we execute secondary we need to mark some stuff to reset dirty */
-       if (commandBufferCount) {
-               primary->state.dirty |= RADV_CMD_DIRTY_PIPELINE;
-               primary->state.dirty |= RADV_CMD_DIRTY_DYNAMIC_ALL;
-               radv_mark_descriptor_sets_dirty(primary);
-       }
+       /* After executing commands from secondary buffers we have to dirty
+        * some states.
+        */
+       primary->state.dirty |= RADV_CMD_DIRTY_PIPELINE;
+       primary->state.dirty |= RADV_CMD_DIRTY_DYNAMIC_ALL;
+       radv_mark_descriptor_sets_dirty(primary);
 }
 
 VkResult radv_CreateCommandPool(