nv30: fix rare issue with fp unbinding not finding the bufctx
authorIlia Mirkin <imirkin@alum.mit.edu>
Thu, 27 Dec 2018 04:01:21 +0000 (23:01 -0500)
committerIlia Mirkin <imirkin@alum.mit.edu>
Mon, 31 Dec 2018 00:44:43 +0000 (19:44 -0500)
If the last-active context gets deleted, the pushbuf doesn't have a
bufctx to reference. Then there could be a sequence of binds which would
trigger a reset on that bin before validation was done. Instead we just
pass in the bufctx in question directly.

All other instances of PUSH_RESET happen strictly after a validation is
run.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102349
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
src/gallium/drivers/nouveau/nv30/nv30_fragprog.c

index 6de61bcc1c00ab3fc972b958cdd446f09ad6fb53..073b2a346707ae9539959a6c6925976ecf0976cb 100644 (file)
@@ -171,7 +171,7 @@ nv30_fp_state_bind(struct pipe_context *pipe, void *hwcso)
     * code
     */
    if (fp != nv30->state.fragprog)
-      PUSH_RESET(nv30->base.pushbuf, BUFCTX_FRAGPROG);
+      nouveau_bufctx_reset(nv30->bufctx, BUFCTX_FRAGPROG);
 
    nv30->fragprog.program = fp;
    nv30->dirty |= NV30_NEW_FRAGPROG;