glsl_type: Add a talloc-based new

And hook it up at the two sites it's called.

Note that with this change we still don't use glsl_type* objects as
talloc contexts, (see things like get_array_instance that accept both
a talloc 'ctx' as well as a glsl_type*). The reason for this is that
the code is still using many instance of glsl_type objects not created
with new.

This closes 3 leaks in the glsl-orangebook-ch06-bump.frag test:

	total heap usage: 55,623 allocs, 55,618

Leaving only 5 leaks to go.

diff --git a/ast_to_hir.cpp b/ast_to_hir.cpp
index 38e344f0d250ed81b8464e4e4f4ee6f4101f6fd5..ddd4b7326622277249ea9fdc4a52c36fe3a68bb2 100644 (file)
--- a/ast_to_hir.cpp
+++ b/ast_to_hir.cpp
@@ -2354,6 +2354,7 @@ ir_rvalue *
 ast_struct_specifier::hir(exec_list *instructions,
                          struct _mesa_glsl_parse_state *state)
 {
+   void *ctx = talloc_parent(state);
    unsigned decl_count = 0;
 
    /* Make an initial pass over the list of structure fields to determine how
@@ -2416,7 +2417,7 @@ ast_struct_specifier::hir(exec_list *instructions,
       name = this->name;
    }
 
-   glsl_type *t = new glsl_type(fields, decl_count, name);
+   glsl_type *t = new(ctx) glsl_type(fields, decl_count, name);
 
    YYLTYPE loc = this->get_location();
    if (!state->symbols->add_type(name, t)) {

diff --git a/glsl_types.cpp b/glsl_types.cpp
index d1b9dc64121b9389c29fdcec887417b0182e4f0b..bef267fa6be5a81ba61699871bdab49fd1fae8f3 100644 (file)
--- a/glsl_types.cpp
+++ b/glsl_types.cpp
@@ -702,7 +702,7 @@ glsl_type::get_array_instance(void *ctx, const glsl_type *base,
 
    const glsl_type *t = (glsl_type *) hash_table_find(array_types, & key);
    if (t == NULL) {
-      t = new glsl_type(ctx, base, array_size);
+      t = new(ctx) glsl_type(ctx, base, array_size);
 
       hash_table_insert(array_types, (void *) t, t);
    }

diff --git a/glsl_types.h b/glsl_types.h
index baec763c42fb2a1cb90c738afc59cee97a99aff7..39e6ac970aa6ff527453c11986c8bef24a5c9a76 100644 (file)
--- a/glsl_types.h
+++ b/glsl_types.h
@@ -29,6 +29,10 @@
 #include <cstring>
 #include <cassert>
 
+extern "C" {
+#include <talloc.h>
+}
+
 #define GLSL_TYPE_UINT          0
 #define GLSL_TYPE_INT           1
 #define GLSL_TYPE_FLOAT         2
@@ -61,6 +65,25 @@ struct glsl_type {
                                * and \c GLSL_TYPE_UINT are valid.
                                */
 
+   /* Callers of this talloc-based new need not call delete. It's
+    * easier to just talloc_free 'ctx' (or any of its ancestors). */
+   static void* operator new(size_t size, void *ctx)
+   {
+      void *type;
+
+      type = talloc_size(ctx, size);
+      assert(type != NULL);
+
+      return type;
+   }
+
+   /* If the user *does* call delete, that's OK, we will just
+    * talloc_free in that case. */
+   static void operator delete(void *type)
+   {
+      talloc_free(type);
+   }
+
    /**
     * \name Vector and matrix element counts
     *