gdb: make use of skip_to_space and skip_spaces

Some late feedback on this commit:

  commit 037d7135de575c9e0c20e9158c105979bfee339c
  Date:   Mon Nov 16 11:36:56 2020 +0000

      gdb: improve command completion for 'print', 'x', and 'display'

Suggested making use of the skip_to_space and skip_spaces helper
functions.  There should be no user visible changes after this commit.

gdb/ChangeLog:

	* printcmd.c (skip_over_slash_fmt): Make use of skip_to_space and
	skip_spaces.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1c0029da355d95651abd6b29f60e73df4c51da5c..46c9d399be7a7670afb704a1ea6210e578daf391 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-11-19  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+       * printcmd.c (skip_over_slash_fmt): Make use of skip_to_space and
+       skip_spaces.
+
 2020-11-18  Keith Seitz  <keiths@redhat.com>
 
        * linux-tdep.c (dump_note_entry_p): Return true instead of

diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index 8c05ac8c8337f8d2769f6fd54a6a3f24c4bd60cc..a9c64b97c81dc6d9422709c7c41a59b18a4af9d0 100644 (file)
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -1261,8 +1261,7 @@ skip_over_slash_fmt (completion_tracker &tracker, const char **args)
       if (ISALNUM (text[1]) || ISSPACE (text[1]))
        {
          /* Skip over the actual format specification.  */
-         while (*text != '\0' && !ISSPACE (*text))
-           ++text;
+         text = skip_to_space (text);
 
          if (*text == '\0')
            {
@@ -1272,8 +1271,7 @@ skip_over_slash_fmt (completion_tracker &tracker, const char **args)
          else
            {
              in_fmt = false;
-             while (ISSPACE (*text))
-               ++text;
+             text = skip_spaces (text);
            }
        }
       else if (text[1] == '\0')