draw: only fill in / compare the part of the translate key we're using.

It's quite a big struct & we examine it a lot (too much).  Reduce
the impact of this by just looking at the active part where possible.

diff --git a/src/gallium/auxiliary/draw/draw_pt_emit.c b/src/gallium/auxiliary/draw/draw_pt_emit.c
index f9ac16786efc4c11e617fd9513ae10491d6750c9..671abc25ce19140140c05680115ea53703b1788b 100644 (file)
--- a/src/gallium/auxiliary/draw/draw_pt_emit.c
+++ b/src/gallium/auxiliary/draw/draw_pt_emit.c
@@ -49,6 +49,7 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
    const struct vertex_info *vinfo;
    unsigned dst_offset;
    struct translate_key hw_key;
+   unsigned keysize;
    unsigned i;
    boolean ok;
 
@@ -58,12 +59,10 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
       return;
    }
 
-   memset(&hw_key, 0, sizeof(hw_key));
-
    /* Must do this after set_primitive() above:
     */
    vinfo = draw->render->get_vertex_info(draw->render);
-
+   keysize = 2*4 + vinfo->num_attribs * sizeof(hw_key.element[0]);
 
    /* Translate from pipeline vertices to hw vertices.
     */
@@ -122,8 +121,9 @@ void draw_pt_emit_prepare( struct pt_emit *emit,
    hw_key.output_stride = vinfo->size * 4;
 
    if (!emit->translate ||
-       memcmp(&emit->translate->key, &hw_key, sizeof(hw_key)) != 0)
+       memcmp(&emit->translate->key, &hw_key, keysize) != 0)
    {
+      memset((char *)&hw_key + keysize, 0, sizeof(hw_key) - keysize);
       emit->translate = translate_cache_find(emit->cache, &hw_key);
    }
 }

diff --git a/src/gallium/auxiliary/draw/draw_pt_fetch.c b/src/gallium/auxiliary/draw/draw_pt_fetch.c
index 1f765b73adf715626c34aa54afbb2079d4088f0e..a5bebb4ca12bcc672e114e9c38bf875419744fe7 100644 (file)
--- a/src/gallium/auxiliary/draw/draw_pt_fetch.c
+++ b/src/gallium/auxiliary/draw/draw_pt_fetch.c
@@ -62,10 +62,11 @@ void draw_pt_fetch_prepare( struct pt_fetch *fetch,
    unsigned i, nr = 0;
    unsigned dst_offset = 0;
    struct translate_key key;
+   unsigned keysize;
 
    fetch->vertex_size = vertex_size;
-
-   memset(&key, 0, sizeof(key));
+   keysize = (2*4 + 
+              (draw->pt.nr_vertex_elements + 1) * sizeof(key.element[0]));
 
    /* Always emit/leave space for a vertex header.
     *
@@ -110,8 +111,9 @@ void draw_pt_fetch_prepare( struct pt_fetch *fetch,
 
 
    if (!fetch->translate ||
-       memcmp(&fetch->translate->key, &key, sizeof(key)) != 0)
+       memcmp(&fetch->translate->key, &key, keysize) != 0)
    {
+      memset((char *)&key + keysize, 0, sizeof(key) - keysize);
       fetch->translate = translate_cache_find(fetch->cache, &key);
 
       {

diff --git a/src/gallium/auxiliary/translate/translate.h b/src/gallium/auxiliary/translate/translate.h
index 6c15d7e4dc7bb3e56a7805ed0af21d79f8c6d317..de6f09d18a299ba4014ff6b948f1f504e3cf9c89 100644 (file)
--- a/src/gallium/auxiliary/translate/translate.h
+++ b/src/gallium/auxiliary/translate/translate.h
@@ -47,10 +47,9 @@
 struct translate_element 
 {
    enum pipe_format input_format;
-   unsigned input_buffer;
-   unsigned input_offset;
-
    enum pipe_format output_format;
+   unsigned input_buffer;
+   unsigned input_offset;       /* can't really reduce the size of these */
    unsigned output_offset;
 };