common-utils-selftests.c: Add ATTRIBUTE_PRINTF

Fix this, when building with clang:

/home/emaisin/src/binutils-gdb/gdb/unittests/common-utils-selftests.c:50:40: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
  std::string result = string_vprintf (fmt, vp);
                                       ^~~
gdb/ChangeLog:

	* unittests/common-utils-selftests.c (format): Add
	ATTRIBUTE_PRINTF.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 51e34227dc9e2849bbf4d84fa38ab1bda0116d95..9fe632985e90fbd6ad773d055918d4fdd0ac6858 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+       * unittests/common-utils-selftests.c (format): Add
+       ATTRIBUTE_PRINTF.
+
 2017-10-27  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * xml-syscall.c (struct syscall_desc): Add constructor.

diff --git a/gdb/unittests/common-utils-selftests.c b/gdb/unittests/common-utils-selftests.c
index 0f26b219af446dee299156ecf8d60e18a3189710..c48904ba0fca6056eb9bfaa81ea4e769af85cd89 100644 (file)
--- a/gdb/unittests/common-utils-selftests.c
+++ b/gdb/unittests/common-utils-selftests.c
@@ -41,7 +41,7 @@ string_printf_tests ()
   SELF_CHECK (string_printf ("%s", X100000) == X100000);
 }
 
-static std::string
+static std::string ATTRIBUTE_PRINTF (1, 2)
 format (const char *fmt, ...)
 {
   va_list vp;