PR gdb/544

	Suggested by Jan Kratochvil:
	* top.c (gdb_rl_operate_and_get_next_completion): Call
	rl_redisplay_function.
	(gdb_rl_redisplay): New.
	(init_main): Set rl_redisplay_function.

	* gdb.cp/annota2.exp, gdb.cp/annota3.exp: Remove KFAIL for
	fixed PR gdb/544.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6a25570944cbd4917c9007a81084a3ee88e36d6d..f96de065af877b4ce7fc1cfd03cdd956102d0770 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2008-03-21  Daniel Jacobowitz  <dan@codesourcery.com>
+
+       PR gdb/544
+       Suggested by Jan Kratochvil:
+       * top.c (gdb_rl_operate_and_get_next_completion): Call
+       rl_redisplay_function.
+       (gdb_rl_redisplay): New.
+       (init_main): Set rl_redisplay_function.
+
 2008-03-21  Thomas Mittelstaedt  <T.Mittelstaedt@cadenas.de>  (tiny change)
 
        * aix-thread.c (pdc_read_regs): Fix compiler warning.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 2f9ee94bd358c2aa47aa8a6c01303f0af6818351..5df1fb39c56d2d8c0c3c65021bfee52676b3e083 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-03-21  Daniel Jacobowitz  <dan@codesourcery.com>
+
+       * gdb.cp/annota2.exp, gdb.cp/annota3.exp: Remove KFAIL for
+       fixed PR gdb/544.
+
 2008-03-21  Pedro Alves  <pedro@codesourcery.com>
 
        * gdb.threads/fork-child-threads.exp: Test next over fork.

diff --git a/gdb/testsuite/gdb.cp/annota2.exp b/gdb/testsuite/gdb.cp/annota2.exp
index 4cf6b711c13e90f5fa118a69bd5cb9803b2bc901..2dd9f4bfaef851f8c7d9d8f13504c9e7eca25b30 100644 (file)
--- a/gdb/testsuite/gdb.cp/annota2.exp
+++ b/gdb/testsuite/gdb.cp/annota2.exp
@@ -205,13 +205,10 @@ gdb_expect {
 # test:
 # annotate-quit
 #
-# This test sometimes fails, but not reproducibly.  See gdb/544.
-#
 send_gdb "\003"
 gdb_expect {
     -re "\r\n\032\032error-begin\r\nQuit\r\n\r\n\032\032quit\r\n$gdb_prompt$" \
            { pass "annotate-quit" }
-    -re "$gdb_prompt$" { kfail "gdb/544" "annotate-quit" }
     -re ".*$gdb_prompt$" { fail "annotate-quit" }
     timeout { fail "annotate-quit (timeout)" }
 }

diff --git a/gdb/testsuite/gdb.cp/annota3.exp b/gdb/testsuite/gdb.cp/annota3.exp
index c2d61682a0e6b03e3272d4f6ef608a8fd1d9088d..7b7e9f9acf5734a50dcc43af133d779227c8c849 100644 (file)
--- a/gdb/testsuite/gdb.cp/annota3.exp
+++ b/gdb/testsuite/gdb.cp/annota3.exp
@@ -208,8 +208,6 @@ gdb_expect {
 # test:
 # annotate-quit
 #
-# This test sometimes fails, but not reproducibly.  See gdb/544.
-#
 send_gdb "\003"
 gdb_expect_list "annotate-quit" "$gdb_prompt$" {
     "\r\n\032\032error-begin\r\n"

diff --git a/gdb/top.c b/gdb/top.c
index 418ff8e95f07f7099fcc0a6faeb2e7fdbddce4e6..505b583250650cc03a5c3308df620f26a0c175c3 100644 (file)
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -921,7 +921,7 @@ gdb_rl_operate_and_get_next_completion (void)
   operate_saved_history = -1;
 
   /* readline doesn't automatically update the display for us.  */
-  rl_redisplay ();
+  rl_redisplay_function ();
 
   after_char_processing_hook = NULL;
   rl_pre_input_hook = NULL;
@@ -956,6 +956,29 @@ gdb_rl_operate_and_get_next (int count, int key)
 
   return rl_newline (1, key);
 }
+
+/* Readline 5.2 and earlier do not block SIGINT while redrawing the prompt.
+   This can lead to corrupted internal state.  As long as we do not require
+   a newer readline version, compensate for it.  */
+static void
+gdb_rl_redisplay (void)
+{
+#if HAVE_SIGPROCMASK
+  sigset_t sigint_set, sigint_oset;
+
+  sigemptyset (&sigint_set);
+  sigemptyset (&sigint_oset);
+  sigaddset (&sigint_set, SIGINT);
+  sigprocmask (SIG_BLOCK, &sigint_set, &sigint_oset);
+#endif
+
+  rl_redisplay ();
+
+#if HAVE_SIGPROCMASK
+  sigprocmask (SIG_SETMASK, &sigint_oset, (sigset_t *)NULL);
+#endif
+}
+
 \f
 /* Read one line from the command input stream `instream'
    into the local static buffer `linebuffer' (whose current length
@@ -1581,6 +1604,7 @@ init_main (void)
   rl_completer_quote_characters = get_gdb_completer_quote_characters ();
   rl_readline_name = "gdb";
   rl_terminal_name = getenv ("TERM");
+  rl_redisplay_function = gdb_rl_redisplay;
 
   /* The name for this defun comes from Bash, where it originated.
      15 is Control-o, the same binding this function has in Bash.  */