Add "const" to a few locals in gdb

I noticed that some code in gdb was doing:

    char *mumble = getenv (...)

However, using "const char *" here would be clearer.
This patch fixes the instances I could readily build.

Tested by rebuilding.

gdb/ChangeLog
2018-09-24  Tom Tromey  <tom@tromey.com>

	* common/pathstuff.c (get_standard_cache_dir): Make
	"xdg_cache_home" and "home" const.
	* top.c (init_history): Make "tmpenv" const.
	* main.c (get_init_files): Make "homedir" const.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e8005c0255420ae0845e3834bb0da35a82f68060..13fac9256f44c5e58f414eef66e1cc68e1a779bc 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-09-24  Tom Tromey  <tom@tromey.com>
+
+       * common/pathstuff.c (get_standard_cache_dir): Make
+       "xdg_cache_home" and "home" const.
+       * top.c (init_history): Make "tmpenv" const.
+       * main.c (get_init_files): Make "homedir" const.
+
 2018-09-23  Tom Tromey  <tom@tromey.com>
 
        PR python/18852:

diff --git a/gdb/common/pathstuff.c b/gdb/common/pathstuff.c
index 3dd58e31aa41817fb98c9f486f9c14afc033a414..82905c9e68742c3abe7133f69f43e4023660693b 100644 (file)
--- a/gdb/common/pathstuff.c
+++ b/gdb/common/pathstuff.c
@@ -171,7 +171,7 @@ get_standard_cache_dir ()
 #endif
 
 #ifndef __APPLE__
-  char *xdg_cache_home = getenv ("XDG_CACHE_HOME");
+  const char *xdg_cache_home = getenv ("XDG_CACHE_HOME");
   if (xdg_cache_home != NULL)
     {
       /* Make sure the path is absolute and tilde-expanded.  */
@@ -180,7 +180,7 @@ get_standard_cache_dir ()
     }
 #endif
 
-  char *home = getenv ("HOME");
+  const char *home = getenv ("HOME");
   if (home != NULL)
     {
       /* Make sure the path is absolute and tilde-expanded.  */

diff --git a/gdb/main.c b/gdb/main.c
index 61644cd0d7d4d030a52c396691f8c94b9d79435b..1552e95f4cd222d0222e8b70c9ae4d71b7157882 100644 (file)
--- a/gdb/main.c
+++ b/gdb/main.c
@@ -208,7 +208,7 @@ get_init_files (const char **system_gdbinit,
   if (!initialized)
     {
       struct stat homebuf, cwdbuf, s;
-      char *homedir;
+      const char *homedir;
 
       if (SYSTEM_GDBINIT[0])
        {

diff --git a/gdb/top.c b/gdb/top.c
index 0a4d36cbea4db0a52dda8cf440be56a21db1d204..4a0fedb6a874c758e67774c06b8747446a112a26 100644 (file)
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -1846,7 +1846,7 @@ set_verbose (const char *args, int from_tty, struct cmd_list_element *c)
 void
 init_history (void)
 {
-  char *tmpenv;
+  const char *tmpenv;
 
   tmpenv = getenv ("GDBHISTSIZE");
   if (tmpenv)