Fix potential NULL pointer dereference

This patch addresses a potential NULL pointer dereference when we try to
duplicate a string. The input pointer can be NULL and that may lead to
crashes. We simply add a check for that case.

gdb/ChangeLog:
2016-10-24  Luis Machado  <lgustavo@codesourcery.com>

	* exec.c (exec_file_locate_attach): Prevent NULL pointer dereference
	when duplicating a string.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 388cc1ff61fbfbf0978d6cd23457fcff40ed0c48..43175ffcde800adf5cd971251788eca2caba34ed 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2016-10-24  Luis Machado  <lgustavo@codesourcery.com>
+
+       * exec.c (exec_file_locate_attach): Prevent NULL pointer dereference
+       when duplicating a string.
+
 2016-10-24  Luis Machado  <lgustavo@codesourcery.com>
 
        * exec.c (exception_print_same): Fix string comparison to use

diff --git a/gdb/exec.c b/gdb/exec.c
index 67ecc6363072cdd7b8b00aaa36085b7c2ccf032f..6e2a296d2e630a28df72994302e1643e8e3c5c2d 100644 (file)
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -227,7 +227,8 @@ exec_file_locate_attach (int pid, int defer_bp_reset, int from_tty)
       prev_err = err;
 
       /* Save message so it doesn't get trashed by the catch below.  */
-      prev_err.message = xstrdup (err.message);
+      if (err.message != NULL)
+       prev_err.message = xstrdup (err.message);
     }
   END_CATCH