PR gdb/8704

	* breakpoint.c (find_condition_and_thread): Correct task error message.
	* c-exp.y (yylex): Stop before "thread N", "task N", or abbreviations
	of those.

	doc/
	* gdb.texinfo (Thread-Specific Breakpoints): Thread specifiers
	are allowed after the breakpoint condition.

	testsuite/
	* gdb.base/condbreak.exp: Test combinations of "break *EXP",
	"if", and "thread".  Correct matching in the previous test.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e69bac29e3080ac6501c7cafcccba0520bf03d52..cf5c907ed9ad05ec806bb05a5f032ecc33ff60e7 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2009-11-24  Daniel Jacobowitz  <dan@codesourcery.com>
+
+       PR gdb/8704
+
+       * breakpoint.c (find_condition_and_thread): Correct task error message.
+       * c-exp.y (yylex): Stop before "thread N", "task N", or abbreviations
+       of those.
+
 2009-11-24  Joel Brobecker  <brobecker@adacore.com>
 
        * acinclude.m4: Include ../config/zlib.m4.

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 8a6813cd866ef73357c6d31bf8db08d0f3f10368..4340c5ddf6abd8b21275b8632f974832792d0c5e 100644 (file)
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -6636,7 +6636,7 @@ find_condition_and_thread (char *tok, CORE_ADDR pc,
          if (tok == tmptok)
            error (_("Junk after task keyword."));
          if (!valid_task_id (*task))
-           error (_("Unknown task %d\n"), *task);
+           error (_("Unknown task %d."), *task);
        }
       else
        error (_("Junk at end of arguments."));

diff --git a/gdb/c-exp.y b/gdb/c-exp.y
index 8ee323e4b78c0810bb66491de4cd51ba80ebc0bc..d657c923f935949a6ccb193f6a689bb884e2326d 100644 (file)
--- a/gdb/c-exp.y
+++ b/gdb/c-exp.y
@@ -2250,6 +2250,24 @@ yylex (void)
       return 0;
     }
 
+  /* For the same reason (breakpoint conditions), "thread N"
+     terminates the expression.  "thread" could be an identifier, but
+     an identifier is never followed by a number without intervening
+     punctuation.  "task" is similar.  Handle abbreviations of these,
+     similarly to breakpoint.c:find_condition_and_thread.  */
+  if (namelen >= 1
+      && (strncmp (tokstart, "thread", namelen) == 0
+         || strncmp (tokstart, "task", namelen) == 0)
+      && (tokstart[namelen] == ' ' || tokstart[namelen] == '\t')
+      && ! scanning_macro_expansion ())
+    {
+      char *p = tokstart + namelen + 1;
+      while (*p == ' ' || *p == '\t')
+       p++;
+      if (*p >= '0' && *p <= '9')
+       return 0;
+    }
+
   lexptr += namelen;
 
   tryname:

diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog
index 8571bc9aebc32ee9bfc67276389268ac973577d8..7c1512412c12dc937927cbf7ed11e60ec471f890 100644 (file)
--- a/gdb/doc/ChangeLog
+++ b/gdb/doc/ChangeLog
@@ -1,3 +1,10 @@
+2009-11-24  Daniel Jacobowitz  <dan@codesourcery.com>
+
+       PR gdb/8704
+
+       * gdb.texinfo (Thread-Specific Breakpoints): Thread specifiers
+       are allowed after the breakpoint condition.
+
 2009-11-23  Tom Tromey  <tromey@redhat.com>
 
        PR python/10782:

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index c1ccfc7826ecccb2a3c55267acf48efc3778d6a2..74cbedffef67dd3f422f44b0903a2ed4031d08e6 100644 (file)
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -5214,8 +5214,8 @@ breakpoint, the breakpoint applies to @emph{all} threads of your
 program.
 
 You can use the @code{thread} qualifier on conditional breakpoints as
-well; in this case, place @samp{thread @var{threadno}} before the
-breakpoint condition, like this:
+well; in this case, place @samp{thread @var{threadno}} before or
+after the breakpoint condition, like this:
 
 @smallexample
 (@value{GDBP}) break frik.c:13 thread 28 if bartab > lim

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 021466fcf63f21af3f45659c4aca8a3a44b4a003..fddb912d64af4573648e4572265a8b860a14a012 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2009-11-24  Daniel Jacobowitz  <dan@codesourcery.com>
+
+       PR gdb/8704
+
+       * gdb.base/condbreak.exp: Test combinations of "break *EXP",
+       "if", and "thread".  Correct matching in the previous test.
+
 2009-11-25  Daniel Jacobowitz  <dan@codesourcery.com>
 
        * gdb.cp/extern-c.cc, gdb.cp/extern-c.exp: New test.

diff --git a/gdb/testsuite/gdb.base/condbreak.exp b/gdb/testsuite/gdb.base/condbreak.exp
index 2fdeb6928e2bab82c31274669e3e344ba7e69a15..8a9dfbcc600bc2a34095f663c295765dd78ed829 100644 (file)
--- a/gdb/testsuite/gdb.base/condbreak.exp
+++ b/gdb/testsuite/gdb.base/condbreak.exp
@@ -207,10 +207,10 @@ gdb_expect {
 setup_xfail hppa2.0w-*-* 11512CLLbs
 send_gdb "continue\n"
 gdb_expect {
-    -re "Continuing\\..*Breakpoint \[0-9\]+, marker2 \\(a=43\\) at .*$srcfile1:($bp_location8|$bp_location9).*($bp_location8|$bp_location9)\[\t \]+.*" {
+    -re "Continuing\\..*Breakpoint \[0-9\]+, marker2 \\(a=43\\) at .*$srcfile1:($bp_location8|$bp_location9).*($bp_location8|$bp_location9)\[\t \]+.*$gdb_prompt $" {
        pass "run until breakpoint at marker2"
     }
-    -re "Continuing\\..*Breakpoint \[0-9\]+, $hex in marker2 \\(a=43\\) at .*$srcfile1:($bp_location8|$bp_location9).*($bp_location8|$bp_location9)\[\t \]+.*" {
+    -re "Continuing\\..*Breakpoint \[0-9\]+, $hex in marker2 \\(a=43\\) at .*$srcfile1:($bp_location8|$bp_location9).*($bp_location8|$bp_location9)\[\t \]+.*$gdb_prompt $" {
        xfail "run until breakpoint at marker2"
     }
     -re "$gdb_prompt $" {
@@ -220,3 +220,30 @@ gdb_expect {
        fail "(timeout) run until breakpoint at marker2"
     }
 }
+
+# Test combinations of conditional and thread-specific breakpoints.
+gdb_test "break main if (1==1) thread 999" \
+    "Unknown thread 999\\."
+gdb_test "break main thread 999 if (1==1)" \
+    "Unknown thread 999\\."
+
+# Verify that both if and thread can be distinguished from a breakpoint
+# address expression.
+gdb_test "break *main if (1==1) thread 999" \
+    "Unknown thread 999\\."
+gdb_test "break *main thread 999 if (1==1)" \
+    "Unknown thread 999\\."
+
+# Similarly for task.
+gdb_test "break *main if (1==1) task 999" \
+    "Unknown task 999\\."
+gdb_test "break *main task 999 if (1==1)" \
+    "Unknown task 999\\."
+
+# GDB accepts abbreviations for "thread" and "task".
+gdb_test "break *main if (1==1) t 999" \
+    "Unknown thread 999\\."
+gdb_test "break *main if (1==1) th 999" \
+    "Unknown thread 999\\."
+gdb_test "break *main if (1==1) ta 999" \
+    "Unknown task 999\\."