Add support for multiple ports on the memory. Hook up simple cpu to memory.

Ready to start testing if I could fix the linking errors I can't ever seem to fix.

cpu/simple/cpu.cc:
cpu/simple/cpu.hh:
    Add connecting of ports until builder can handle it.
mem/physical.cc:
    Add function to allocate a port in the object

    Remove some full_sys stuff untill needed
mem/physical.hh:
    Add function to allocate a port in the object
python/m5/objects/BaseCPU.py:
    Update the params
sim/process.cc:
    Make sure to use the right name (hopefully CPU constructor already called)

--HG--
extra : convert_revision : 4089caf20d7eb53e5463c8ac93ddce5e43ea5d85

diff --git a/cpu/simple/cpu.cc b/cpu/simple/cpu.cc
index c34cf9079bb3e4a9d17e3f45ac3da7431ced5908..7da000a35d7ac389f25c6b5d004c715c3d7473e3 100644 (file)
--- a/cpu/simple/cpu.cc
+++ b/cpu/simple/cpu.cc
@@ -143,6 +143,17 @@ SimpleCPU::SimpleCPU(Params *p)
 
     memPort = &dcachePort;
 
+    //Create Memory Ports (conect them up)
+    p->mem->addPort("DCACHE");
+    dcachePort.setPeer(p->mem->getPort("DCACHE"));
+    (p->mem->getPort("DCACHE"))->setPeer(&dcachePort);
+
+    p->mem->addPort("ICACHE");
+    icachePort.setPeer(p->mem->getPort("ICACHE"));
+    (p->mem->getPort("ICACHE"))->setPeer(&icachePort);
+
+
+
     req = new CpuRequest;
 
     req->asid = 0;
@@ -1019,11 +1030,11 @@ BEGIN_DECLARE_SIM_OBJECT_PARAMS(SimpleCPU)
 #if FULL_SYSTEM
     SimObjectParam<AlphaITB *> itb;
     SimObjectParam<AlphaDTB *> dtb;
-    SimObjectParam<FunctionalMemory *> mem;
     SimObjectParam<System *> system;
     Param<int> cpu_id;
     Param<Tick> profile;
 #else
+    SimObjectParam<Memory *> mem;
     SimObjectParam<Process *> workload;
 #endif // FULL_SYSTEM
 
@@ -1050,11 +1061,11 @@ BEGIN_INIT_SIM_OBJECT_PARAMS(SimpleCPU)
 #if FULL_SYSTEM
     INIT_PARAM(itb, "Instruction TLB"),
     INIT_PARAM(dtb, "Data TLB"),
-    INIT_PARAM(mem, "memory"),
     INIT_PARAM(system, "system object"),
     INIT_PARAM(cpu_id, "processor ID"),
     INIT_PARAM(profile, ""),
 #else
+    INIT_PARAM(mem, "memory"),
     INIT_PARAM(workload, "processes to run"),
 #endif // FULL_SYSTEM
 
@@ -1085,11 +1096,11 @@ CREATE_SIM_OBJECT(SimpleCPU)
 #if FULL_SYSTEM
     params->itb = itb;
     params->dtb = dtb;
-    params->mem = mem;
     params->system = system;
     params->cpu_id = cpu_id;
     params->profile = profile;
 #else
+    params->mem = mem;
     params->process = workload;
 #endif
 

diff --git a/cpu/simple/cpu.hh b/cpu/simple/cpu.hh
index 6df553fe21b5c97eef1163b0c52c3d8e22435205..3354166ccef62de63dddfeda342bfb88c95ed59d 100644 (file)
--- a/cpu/simple/cpu.hh
+++ b/cpu/simple/cpu.hh
@@ -46,7 +46,7 @@
 class Processor;
 class AlphaITB;
 class AlphaDTB;
-class PhysicalMemory;
+class Memory;
 
 class RemoteGDB;
 class GDBListener;
@@ -164,8 +164,8 @@ class SimpleCPU : public BaseCPU
 #if FULL_SYSTEM
         AlphaITB *itb;
         AlphaDTB *dtb;
-        FunctionalMemory *mem;
 #else
+        Memory *mem;
         Process *process;
 #endif
     };

diff --git a/mem/physical.cc b/mem/physical.cc
index 58c9ea408b807521204bfdedcddbfdb1be35fb5e..d7c6345be66a3b4efac8a7bed10bcc64368a6e47 100644 (file)
--- a/mem/physical.cc
+++ b/mem/physical.cc
@@ -40,9 +40,6 @@
 
 #include "base/misc.hh"
 #include "config/full_system.hh"
-#if FULL_SYSTEM
-#include "mem/functional/memory_control.hh"
-#endif
 #include "mem/physical.hh"
 #include "sim/host.hh"
 #include "sim/builder.hh"
@@ -71,46 +68,8 @@ PhysicalMemory::MemResponseEvent::description()
     return "Physical Memory Timing Access respnse event";
 }
 
-#if FULL_SYSTEM
-PhysicalMemory::PhysicalMemory(const string &n, Range<Addr> range,
-                               MemoryController *mmu, const std::string &fname)
-    : Memory(n), base_addr(range.start), pmem_size(range.size()),
-      pmem_addr(NULL)
-{
-    if (pmem_size % TheISA::PageBytes != 0)
-        panic("Memory Size not divisible by page size\n");
-
-    mmu->add_child(this, range);
-
-    int fd = -1;
-
-    if (!fname.empty()) {
-        fd = open(fname.c_str(), O_RDWR | O_CREAT, 0644);
-        if (fd == -1) {
-            perror("open");
-            fatal("Could not open physical memory file: %s\n", fname);
-        }
-        ftruncate(fd, pmem_size);
-    }
-
-    int map_flags = (fd == -1) ? (MAP_ANON | MAP_PRIVATE) : MAP_SHARED;
-    pmem_addr = (uint8_t *)mmap(NULL, pmem_size, PROT_READ | PROT_WRITE,
-                                map_flags, fd, 0);
-
-    if (fd != -1)
-        close(fd);
-
-    if (pmem_addr == (void *)MAP_FAILED) {
-        perror("mmap");
-        fatal("Could not mmap!\n");
-    }
-
-    page_ptr = 0;
-}
-#endif
-
 PhysicalMemory::PhysicalMemory(const string &n)
-    : Memory(n), memoryPort(this), base_addr(0), pmem_addr(NULL)
+    : Memory(n), base_addr(0), pmem_addr(NULL)
 {
     // Hardcoded to 128 MB for now.
     pmem_size = 1 << 27;
@@ -134,6 +93,7 @@ PhysicalMemory::~PhysicalMemory()
 {
     if (pmem_addr)
         munmap(pmem_addr, pmem_size);
+    //Remove memPorts?
 }
 
 Addr
@@ -146,6 +106,13 @@ PhysicalMemory::new_page()
     return return_addr;
 }
 
+Port *
+PhysicalMemory::addPort(std::string portName)
+{
+    memoryPortList[portName] = new MemoryPort(this);
+    return memoryPortList[portName];
+}
+
 //
 // little helper for better prot_* error messages
 //
@@ -174,11 +141,11 @@ PhysicalMemory::deviceBlockSize()
 }
 
 bool
-PhysicalMemory::doTimingAccess (Packet &pkt)
+PhysicalMemory::doTimingAccess (Packet &pkt, MemoryPort* memoryPort)
 {
     doFunctionalAccess(pkt);
 
-    MemResponseEvent* response = new MemResponseEvent(pkt, &memoryPort);
+    MemResponseEvent* response = new MemResponseEvent(pkt, memoryPort);
     response->schedule(curTick + lat);
 
     return true;
@@ -210,7 +177,10 @@ PhysicalMemory::doFunctionalAccess(Packet &pkt)
 Port *
 PhysicalMemory::getPort(const char *if_name)
 {
-    return &memoryPort;
+    if (memoryPortList.find(if_name) != memoryPortList.end())
+        return memoryPortList[if_name];
+    else
+        panic("Looking for a port that didn't exist\n");
 }
 
 void
@@ -245,7 +215,7 @@ PhysicalMemory::MemoryPort::deviceBlockSize()
 bool
 PhysicalMemory::MemoryPort::recvTiming(Packet &pkt)
 {
-    return memory->doTimingAccess(pkt);
+    return memory->doTimingAccess(pkt, this);
 }
 
 Tick

diff --git a/mem/physical.hh b/mem/physical.hh
index b31e45ac52abfdb40f370d8b146823e102fd3058..fb2d0d74342a5cb243d611b96c3a03a05c70c518 100644 (file)
--- a/mem/physical.hh
+++ b/mem/physical.hh
@@ -37,7 +37,8 @@
 #include "mem/packet.hh"
 #include "mem/port.hh"
 #include "sim/eventq.hh"
-
+#include <map>
+#include <string>
 //
 // Functional model for a contiguous block of physical memory. (i.e. RAM)
 //
@@ -67,10 +68,14 @@ class PhysicalMemory : public Memory
         virtual int deviceBlockSize();
     };
 
-    MemoryPort memoryPort;
+    std::map<std::string, MemoryPort*> memoryPortList;
 
     Port * PhysicalMemory::getPort(const char *if_name);
 
+    Port * addPort(std::string portName);
+
+    int numPorts;
+
     int lat;
 
     struct MemResponseEvent : public Event
@@ -114,7 +119,7 @@ class PhysicalMemory : public Memory
     // fast back-door memory access for vtophys(), remote gdb, etc.
     // uint64_t phys_read_qword(Addr addr) const;
   private:
-    bool doTimingAccess(Packet &pkt);
+    bool doTimingAccess(Packet &pkt, MemoryPort *memoryPort);
     Tick doAtomicAccess(Packet &pkt);
     void doFunctionalAccess(Packet &pkt);
 

diff --git a/python/m5/objects/BaseCPU.py b/python/m5/objects/BaseCPU.py
index a902037297a1b1a11a103c44e30e5ece448beb2f..fac452285d8e842083a52434da8fab0a7d335bd7 100644 (file)
--- a/python/m5/objects/BaseCPU.py
+++ b/python/m5/objects/BaseCPU.py
@@ -8,10 +8,10 @@ class BaseCPU(SimObject):
     if build_env['FULL_SYSTEM']:
         dtb = Param.AlphaDTB("Data TLB")
         itb = Param.AlphaITB("Instruction TLB")
-        mem = Param.FunctionalMemory("memory")
         system = Param.System(Parent.any, "system object")
         cpu_id = Param.Int(-1, "CPU identifier")
     else:
+        mem = Param.Memory("memory")
         workload = VectorParam.Process("processes to run")
 
     max_insts_all_threads = Param.Counter(0,

diff --git a/sim/process.cc b/sim/process.cc
index 2335d5cc82fd0f88cbb23b61e21a4c6472c1d616..ac2aae5d470ea5330783de1cba034dde10e4b4d3 100644 (file)
--- a/sim/process.cc
+++ b/sim/process.cc
@@ -154,7 +154,7 @@ Process::startup()
     if (execContexts.empty())
         fatal("Process %s is not associated with any CPUs!\n", name());
 
-    initVirtMem = new TranslatingPort((system->physmem->getPort("any"))->getPeer(), pTable);
+    initVirtMem = new TranslatingPort((system->physmem->getPort("DCACHE"))->getPeer(), pTable);
 
     // first exec context for this process... initialize & enable
     ExecContext *xc = execContexts[0];