Fix incorrect use of 'is' operator for comparison in python/lib/gdb/command/prompt.py

The 'is' operator is not meant to be used for comparisons. It currently working
is an implementation detail of CPython.  CPython 3.8 has added a SyntaxWarning
for this.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 383b3533390ebb5ed0dd33dad0e44c1b2f2b9989..7eb5d9aef31d8d3e665579da93ae928be6b3af08 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-05-04  Raul Tambre  <raul@tambre.ee>
+
+       * python/lib/gdb/prompt.py (_ExtendedPrompt)
+       <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
+       operator for comparison.
+
 2019-05-04  Tom Tromey  <tom@tromey.com>
 
        * psymtab.c (psymbol_name_matches, match_partial_symbol)

diff --git a/gdb/python/lib/gdb/command/prompt.py b/gdb/python/lib/gdb/command/prompt.py
index 3d662a7d3f1bfa3ebbe3456ffab1f331c982d8c5..04b9e49c229f8b16c5a07b9c73ce9d2b39213ae8 100644 (file)
--- a/gdb/python/lib/gdb/command/prompt.py
+++ b/gdb/python/lib/gdb/command/prompt.py
@@ -45,7 +45,7 @@ The currently defined substitutions are:
         self.hook_set = False
 
     def get_show_string (self, pvalue):
-        if self.value is not '':
+        if self.value:
            return "The extended prompt is: " + self.value
         else:
            return "The extended prompt is not set."
@@ -57,7 +57,7 @@ The currently defined substitutions are:
         return ""
 
     def before_prompt_hook(self, current):
-        if self.value is not '':
+        if self.value:
             return gdb.prompt.substitute_prompt(self.value)
         else:
             return None