mesa/formatquery: remove online compression check on is_resource_supported
authorAlejandro Piñeiro <apinheiro@igalia.com>
Fri, 4 May 2018 14:44:44 +0000 (16:44 +0200)
committerAlejandro Piñeiro <apinheiro@igalia.com>
Tue, 8 May 2018 06:19:38 +0000 (08:19 +0200)
is_resource_supported returns if the combination of
target/internalformat is supported in at least one operation. Online
compression is only mandatory for glTexImage2D. Some formats doesn't
support online compression, but can be used in any case, with
glCompressed*D methods.

Without this commit, ETC2 internalformats were returning FALSE, even
for the drivers supporting it. So any other query (like
TEXTURE_COMPRESSED) was returning FALSE/NONE instead of the proper
value.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/mesa/main/formatquery.c

index 3b000fac5c4f117f1284ff86f656b20a3f213c74..84b5f512ba524cb28f28867aad09498548e3ccea 100644 (file)
@@ -501,8 +501,7 @@ _is_resource_supported(struct gl_context *ctx, GLenum target,
 
       /* additional checks for compressed textures */
       if (_mesa_is_compressed_format(ctx, internalformat) &&
-          (!_mesa_target_can_be_compressed(ctx, target, internalformat, NULL) ||
-           _mesa_format_no_online_compression(internalformat)))
+          !_mesa_target_can_be_compressed(ctx, target, internalformat, NULL))
          return false;
 
       break;