[gdb/tdep] Handle static field in i386_16_byte_align_p

When running test-case on gdb.cp/many-args.exp with target board unix/-m32, I
run into:
...
(gdb) p check_val (ref_val, ref_val, ... , ref_val, ref_val)^M
$1 = false^M
(gdb) FAIL: gdb.cp/many-args.exp: check passing many structures
...

The test source contains struct ss:
...
typedef int v4si __attribute__ ((vector_size (16)));

struct ss
{
  static v4si static_field;
  unsigned char aa;
};
...
and i386_16_byte_align_p returns true for this type.

Fix this by skipping static fields in i386_16_byte_align_p.

Tested on x86_64-linux.

gdb/ChangeLog:

2020-12-04  Tom de Vries  <tdevries@suse.de>

	PR tdep/27007
	* i386-tdep.c (i386_16_byte_align_p): Skip static fields.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 75d7422559d09832ca9814cca60303cc7fb0097c..bbd50291bb48bf13e848d2e06313b629a945bcfd 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-12-04  Tom de Vries  <tdevries@suse.de>
+
+       PR tdep/27007
+       * i386-tdep.c (i386_16_byte_align_p): Skip static fields.
+
 2020-12-03  Simon Marchi  <simon.marchi@polymtl.ca>
 
        PR gdb/26876

diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 00de4e1ccb9ed670d97241798ce409c92011024e..ad02ad679bc839a6f8c299a1d076f8b89ebecb0b 100644 (file)
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -2644,6 +2644,8 @@ i386_16_byte_align_p (struct type *type)
       int i;
       for (i = 0; i < type->num_fields (); i++)
        {
+         if (field_is_static (&type->field (i)))
+           continue;
          if (i386_16_byte_align_p (type->field (i).type ()))
            return 1;
        }