libctf, types: ensure the emission of ECTF_NOPARENT

ctf_variable_iter was returning a (positive!) error code rather than
setting the error in the passed-in ctf_file_t.

Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
libctf/
	* ctf-types.c (ctf_variable_iter): Fix error return.

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index 45caf217cb22244ad586c26f80b5d8909f777a90..f3ac4cc91e7798f921d97a90a592e750d12ec7c1 100644 (file)
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,7 @@
+2020-07-22  Egeyar Bagcioglu  <egeyar.bagcioglu@oracle.com>
+
+       * ctf-types.c (ctf_variable_iter): Fix error return.
+
 2020-07-22  Nick Alcock  <nick.alcock@oracle.com>
 
        * ctf-open.c (ctf_bufopen_internal): Diagnose invalid flags.

diff --git a/libctf/ctf-types.c b/libctf/ctf-types.c
index d7ed0e31dca3d3926e59f9a4d15c439d5e7ee135..550068250fda4edf974cce5527152c076673faf9 100644 (file)
--- a/libctf/ctf-types.c
+++ b/libctf/ctf-types.c
@@ -495,7 +495,7 @@ ctf_variable_iter (ctf_file_t *fp, ctf_variable_f *func, void *arg)
   int rc;
 
   if ((fp->ctf_flags & LCTF_CHILD) && (fp->ctf_parent == NULL))
-    return ECTF_NOPARENT;
+    return (ctf_set_errno (fp, ECTF_NOPARENT));
 
   if (!(fp->ctf_flags & LCTF_RDWR))
     {