ac/gpu_info: add kernel_flushes_hdp_before_ib
authorMarek Olšák <marek.olsak@amd.com>
Wed, 2 May 2018 22:27:18 +0000 (18:27 -0400)
committerMarek Olšák <marek.olsak@amd.com>
Thu, 10 May 2018 22:39:47 +0000 (18:39 -0400)
Reviewed-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
src/amd/common/ac_gpu_info.c
src/amd/common/ac_gpu_info.h
src/gallium/drivers/radeonsi/si_buffer.c
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c

index 1725bb0486aabfb8bc6ffd86c1f0190f47fdd6be..5b72d4985bda6ffea8333202698192dc00d3b749 100644 (file)
@@ -316,6 +316,7 @@ bool ac_query_gpu_info(int fd, amdgpu_device_handle dev,
        /* TODO: Enable this once the kernel handles it efficiently. */
        info->has_local_buffers = info->drm_minor >= 20 &&
                                  !info->has_dedicated_vram;
+       info->kernel_flushes_hdp_before_ib = true;
 
        info->num_render_backends = amdinfo->rb_pipes;
        /* The value returned by the kernel driver was wrong. */
@@ -463,6 +464,7 @@ void ac_print_gpu_info(struct radeon_info *info)
        printf("    has_fence_to_handle = %u\n", info->has_fence_to_handle);
        printf("    has_ctx_priority = %u\n", info->has_ctx_priority);
        printf("    has_local_buffers = %u\n", info->has_local_buffers);
+       printf("    kernel_flushes_hdp_before_ib = %u\n", info->kernel_flushes_hdp_before_ib);
 
        printf("Shader core info:\n");
        printf("    max_shader_clock = %i\n", info->max_shader_clock);
index 7af6fbfca9718cd99abcafc7fa3d51e4450b61ca..8a9721750a6b5774b6e65d7c6a45b08165b45c91 100644 (file)
@@ -96,6 +96,7 @@ struct radeon_info {
        bool                        has_fence_to_handle;
        bool                        has_ctx_priority;
        bool                        has_local_buffers;
+       bool                        kernel_flushes_hdp_before_ib;
 
        /* Shader cores. */
        uint32_t                    r600_max_quad_pipes; /* wave size / 16 */
index 504e0c723dce7170a851e056f7f396911614cc1c..2d68edc3404ddf3d418e95c74c8643d26c40f219 100644 (file)
@@ -125,8 +125,7 @@ void si_init_resource_fields(struct si_screen *sscreen,
                /* Older kernels didn't always flush the HDP cache before
                 * CS execution
                 */
-               if (sscreen->info.drm_major == 2 &&
-                   sscreen->info.drm_minor < 40) {
+               if (!sscreen->info.kernel_flushes_hdp_before_ib) {
                        res->domains = RADEON_DOMAIN_GTT;
                        res->flags |= RADEON_FLAG_GTT_WC;
                        break;
@@ -153,8 +152,7 @@ void si_init_resource_fields(struct si_screen *sscreen,
                 * ensures all CPU writes finish before the GPU
                 * executes a command stream.
                 */
-               if (sscreen->info.drm_major == 2 &&
-                   sscreen->info.drm_minor < 40)
+               if (!sscreen->info.kernel_flushes_hdp_before_ib)
                        res->domains = RADEON_DOMAIN_GTT;
        }
 
index 253dd4e2eb6e3262d3a87f622dec6ca334757abf..6e3162d1cf38ab851ba664b58c93eca85c74ef2d 100644 (file)
@@ -528,6 +528,7 @@ static bool do_winsys_init(struct radeon_drm_winsys *ws)
                                      ws->accel_working2 < 3);
     ws->info.tcc_cache_line_size = 64; /* TC L2 line size on GCN */
     ws->info.ib_start_alignment = 4096;
+    ws->info.kernel_flushes_hdp_before_ib = ws->info.drm_minor >= 40;
 
     ws->check_vm = strstr(debug_get_option("R600_DEBUG", ""), "check_vm") != NULL;