remove erroneous return from setup_user_args

This fixes setup_user_args to drop a useless and confusing "return".

	* cli/cli-script.c (setup_user_args): Don't return after error.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2345ff8003a7f7de26ee36e898410a0d07c4f469..eaa47a08910798c00230eca51633e1867102fc54 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-05-30  Tom Tromey  <tromey@redhat.com>
+
+       * cli/cli-script.c (setup_user_args): Don't return after error.
+
 2013-05-30  Tom Tromey  <tromey@redhat.com>
 
        * somread.c (som_symtab_read): Call do_cleanups.

diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
index 3b24799755289d853957fecae659aab3ec202cf0..43fd4796d6f82ff53e573785375359035984c02b 100644 (file)
--- a/gdb/cli/cli-script.c
+++ b/gdb/cli/cli-script.c
@@ -689,11 +689,8 @@ setup_user_args (char *p)
       int bsquote = 0;
 
       if (arg_count >= MAXUSERARGS)
-       {
-         error (_("user defined function may only have %d arguments."),
-                MAXUSERARGS);
-         return old_chain;
-       }
+       error (_("user defined function may only have %d arguments."),
+              MAXUSERARGS);
 
       /* Strip whitespace.  */
       while (*p == ' ' || *p == '\t')