Inline expression constructor

The struct expression constructor no longer does any real work, so
this inlines it.  The default destructor can also be used now as well.

gdb/ChangeLog
2021-03-08  Tom Tromey  <tom@tromey.com>

	* parse.c (expression::expression, expression::~expression):
	Remove.
	* expression.h (struct expression): Inline constructor.  Remove
	destructor.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 97f029f402c89014a7e6853b1e145cd8f823b7d6..e2f6368af4dc0c94e139bdc9f017a15680a0a7a6 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2021-03-08  Tom Tromey  <tom@tromey.com>
+
+       * parse.c (expression::expression, expression::~expression):
+       Remove.
+       * expression.h (struct expression): Inline constructor.  Remove
+       destructor.
+
 2021-03-08  Tom Tromey  <tom@tromey.com>
 
        * std-operator.def (BINOP_END): Remove.

diff --git a/gdb/expression.h b/gdb/expression.h
index eae986af747fc79e6c18bd3d81ab9734e10b137e..5c5371e9660d7585f33bd23c65944506c5e278c9 100644 (file)
--- a/gdb/expression.h
+++ b/gdb/expression.h
@@ -196,8 +196,12 @@ make_operation (Arg... args)
 
 struct expression
 {
-  expression (const struct language_defn *, struct gdbarch *);
-  ~expression ();
+  expression (const struct language_defn *lang, struct gdbarch *arch)
+    : language_defn (lang),
+      gdbarch (arch)
+  {
+  }
+
   DISABLE_COPY_AND_ASSIGN (expression);
 
   /* Return the opcode for the outermost sub-expression of this

diff --git a/gdb/parse.c b/gdb/parse.c
index 96dd5dbf7a00b6d5bec8c7bdea3d1b664ac4f4d2..d068c94dfcd50be44cd9e7af3985def6f82f9707 100644 (file)
--- a/gdb/parse.c
+++ b/gdb/parse.c
@@ -105,16 +105,6 @@ expr_builder::release ()
   return std::move (expout);
 }
 
-expression::expression (const struct language_defn *lang, struct gdbarch *arch)
-  : language_defn (lang),
-    gdbarch (arch)
-{
-}
-
-expression::~expression ()
-{
-}
-
 /* Return the type of MSYMBOL, a minimal symbol of OBJFILE.  If
    ADDRESS_P is not NULL, set it to the MSYMBOL's resolved
    address.  */