* srec.c (srec_canonicalize_symtab): Don't alloc when symcount

	is zero.  Correct return value on error.
	* mmo.c (mmo_canonicalize_symtab): Likewise.
	* binary.c (binary_canonicalize_symtab) Correct return on error.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 53bfe0d52b27ffb06b4090be00b59cc1fe25830c..9bef708ab1610acb8bb6c2dc283bd817fc91f2dc 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2007-07-26  Alan Modra  <amodra@bigpond.net.au>
+
+       * srec.c (srec_canonicalize_symtab): Don't alloc when symcount
+       is zero.  Correct return value on error.
+       * mmo.c (mmo_canonicalize_symtab): Likewise.
+       * binary.c (binary_canonicalize_symtab) Correct return on error.
+
 2007-07-26  Thiemo Seufer  <ths@mips.com>
 
        * bfd.c (_bfd_set_gp_value): Use abort instead of BFD_FAIL.

diff --git a/bfd/binary.c b/bfd/binary.c
index 38d0cc3fd4e8c6b59362e5ec989946e73cdceeaf..c4aec2ba61505d3de7aa56dcd0a3160db0903611 100644 (file)
--- a/bfd/binary.c
+++ b/bfd/binary.c
@@ -169,7 +169,7 @@ binary_canonicalize_symtab (bfd *abfd, asymbol **alocation)
 
   syms = bfd_alloc (abfd, amt);
   if (syms == NULL)
-    return 0;
+    return -1;
 
   /* Start symbol.  */
   syms[0].the_bfd = abfd;

diff --git a/bfd/mmo.c b/bfd/mmo.c
index 0d3e9633e73fedefe066782cd1346f628de798fb..c0e8082826f81f5092a4292423d93bc48677f51e 100644 (file)
--- a/bfd/mmo.c
+++ b/bfd/mmo.c
@@ -2097,7 +2097,7 @@ mmo_canonicalize_symtab (bfd *abfd, asymbol **alocation)
   unsigned int i;
 
   csymbols = abfd->tdata.mmo_data->csymbols;
-  if (csymbols == NULL)
+  if (csymbols == NULL && symcount != 0)
     {
       asymbol *c;
       struct mmo_symbol *s;
@@ -2119,8 +2119,8 @@ mmo_canonicalize_symtab (bfd *abfd, asymbol **alocation)
             mmo_sort_mmo_symbols);
 
       csymbols = (asymbol *) bfd_alloc (abfd, symcount * sizeof (asymbol));
-      if (csymbols == NULL && symcount != 0)
-       return FALSE;
+      if (csymbols == NULL)
+       return -1;
       abfd->tdata.mmo_data->csymbols = csymbols;
 
       for (msp = (struct mmo_symbol **) alocation, c = csymbols;

diff --git a/bfd/srec.c b/bfd/srec.c
index cd61cd2dc35f685cc088799b70a0c62aeec4fd7d..a5f588c231e99c811e3f5d8990900f5218745541 100644 (file)
--- a/bfd/srec.c
+++ b/bfd/srec.c
@@ -1125,14 +1125,14 @@ srec_canonicalize_symtab (bfd *abfd, asymbol **alocation)
   unsigned int i;
 
   csymbols = abfd->tdata.srec_data->csymbols;
-  if (csymbols == NULL)
+  if (csymbols == NULL && symcount != 0)
     {
       asymbol *c;
       struct srec_symbol *s;
 
       csymbols = bfd_alloc (abfd, symcount * sizeof (asymbol));
-      if (csymbols == NULL && symcount != 0)
-       return 0;
+      if (csymbols == NULL)
+       return -1;
       abfd->tdata.srec_data->csymbols = csymbols;
 
       for (s = abfd->tdata.srec_data->symbols, c = csymbols;