ARM: Get rid of some comments/todos that no longer apply.
authorAli Saidi <saidi@eecs.umich.edu>
Mon, 11 Apr 2011 01:02:28 +0000 (21:02 -0400)
committerAli Saidi <saidi@eecs.umich.edu>
Mon, 11 Apr 2011 01:02:28 +0000 (21:02 -0400)
src/arch/arm/linux/process.cc

index fc48ec12d0854210f0fea0a5c7a87812566b47c2..8cf113a60137fa9da78ed8b1da560fceba8b4c7b 100644 (file)
@@ -518,8 +518,6 @@ ArmLinuxProcess::startup()
                                     swiNeg1, sizeof(swiNeg1));
     }
 
-    // We don't have barriers, so just return.
-    // @todo Add a barrrier in this code
     uint8_t memory_barrier[] =
     {
         0x5f, 0xf0, 0x7f, 0xf5, // dmb
@@ -528,9 +526,6 @@ ArmLinuxProcess::startup()
     tc->getMemPort()->writeBlob(commPage + 0x0fa0, memory_barrier,
                                 sizeof(memory_barrier));
 
-    // This -should- be atomic, but I don't think all the support that we'd
-    // need is implemented. There should also be memory barriers around it.
-    // @todo replace this with ldrex/strex and dmb
     uint8_t cmpxchg[] =
     {
         0x9f, 0x3f, 0x92, 0xe1,  // ldrex    r3, [r2]