radv: return correct error on invalid handle from vkAllocateMemory
authorDave Airlie <airlied@redhat.com>
Mon, 12 Jun 2017 19:48:40 +0000 (05:48 +1000)
committerDave Airlie <airlied@redhat.com>
Mon, 12 Jun 2017 23:30:19 +0000 (09:30 +1000)
Coverity pointed out this was returning uninitialised.

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Signed-off-by: Dave Airlie <airlied@redhat.com>
src/amd/vulkan/radv_device.c

index 1ea69608a14b259796c5b74ee75dcc8b6701b366..427d35769d948621baad7ca0bc533a4270d7af3e 100644 (file)
@@ -2108,9 +2108,10 @@ VkResult radv_AllocateMemory(
                       VK_EXTERNAL_MEMORY_HANDLE_TYPE_OPAQUE_FD_BIT_KHX);
                mem->bo = device->ws->buffer_from_fd(device->ws, import_info->fd,
                                                     NULL, NULL);
-               if (!mem->bo)
+               if (!mem->bo) {
+                       result = VK_ERROR_INVALID_EXTERNAL_HANDLE_KHX;
                        goto fail;
-               else
+               else
                        goto out_success;
        }