freedreno: fix dereference before null check
authorRob Clark <robclark@freedesktop.org>
Thu, 2 Jun 2016 14:33:08 +0000 (10:33 -0400)
committerRob Clark <robclark@freedesktop.org>
Thu, 2 Jun 2016 19:44:07 +0000 (15:44 -0400)
ptr can actually never be null so just drop the check.

CID 1362464 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking ptr suggests that it may be null,
but it has already been dereferenced on all paths leading to the check.

Signed-off-by: Rob Clark <robclark@freedesktop.org>
src/gallium/drivers/freedreno/freedreno_query_hw.h

index 8a5d114d806150c6a14b10b013269b0d8bddbf15..095140ea033f425c2c0f21206f8b7b5d730d72d2 100644 (file)
@@ -163,8 +163,7 @@ fd_hw_sample_reference(struct fd_context *ctx,
 
        if (pipe_reference(&(*ptr)->reference, &samp->reference))
                __fd_hw_sample_destroy(ctx, old_samp);
-       if (ptr)
-               *ptr = samp;
+       *ptr = samp;
 }
 
 #endif /* FREEDRENO_QUERY_HW_H_ */