Break out default pbytes argument to read and get_view routines,

adding new routines.

diff --git a/gold/archive.cc b/gold/archive.cc
index ef6ff749b052bad44d494d5f08995215d1ee40b3..f7194f8fea0b30b3fa9c8da25c95029fcd479b1b 100644 (file)
--- a/gold/archive.cc
+++ b/gold/archive.cc
@@ -329,8 +329,9 @@ Archive::include_all_members(Symbol_table* symtab, Layout* layout,
   while (true)
     {
       off_t bytes;
-      const unsigned char* p = this->get_view(off, sizeof(Archive_header),
-                                              &bytes);
+      const unsigned char* p = this->get_view_and_size(off,
+                                                      sizeof(Archive_header),
+                                                      &bytes);
       if (bytes < sizeof(Archive_header))
         {
           if (bytes != 0)
@@ -379,9 +380,8 @@ Archive::include_member(Symbol_table* symtab, Layout* layout,
   // Read enough of the file to pick up the entire ELF header.
   int ehdr_size = elfcpp::Elf_sizes<64>::ehdr_size;
   off_t bytes;
-  const unsigned char* p = this->input_file_->file().get_view(memoff,
-                                                             ehdr_size,
-                                                             &bytes);
+  const unsigned char* p =
+    this->input_file_->file().get_view_and_size(memoff, ehdr_size, &bytes);
   if (bytes < 4)
     {
       fprintf(stderr, _("%s: %s: member at %ld is not an ELF object"),

diff --git a/gold/archive.h b/gold/archive.h
index 8c35d2278be50dde3e8149e6e9a102f993a975da..7fa1d11ae80115550ad3e6df053e1befff6bb77e 100644 (file)
--- a/gold/archive.h
+++ b/gold/archive.h
@@ -98,8 +98,12 @@ class Archive
 
   // Get a view into the underlying file.
   const unsigned char*
-  get_view(off_t start, off_t size, off_t* pbytes = NULL)
-  { return this->input_file_->file().get_view(start, size, pbytes); }
+  get_view(off_t start, off_t size)
+  { return this->input_file_->file().get_view(start, size); }
+
+  const unsigned char*
+  get_view_and_size(off_t start, off_t size, off_t* pbytes)
+  { return this->input_file_->file().get_view_and_size(start, size, pbytes); }
 
   // Read the archive symbol map.
   void

diff --git a/gold/fileread.cc b/gold/fileread.cc
index 8fad789399f3f9b6630b071f7592b7141cc83457..a39d530ab8753ed65b567a3405e0e9b32eb5da63 100644 (file)
--- a/gold/fileread.cc
+++ b/gold/fileread.cc
@@ -202,8 +202,25 @@ File_read::do_read(off_t start, off_t size, void* p, off_t* pbytes)
   return bytes;
 }
 
+// Read data from the file.
+
 void
-File_read::read(off_t start, off_t size, void* p, off_t* pbytes)
+File_read::read(off_t start, off_t size, void* p)
+{
+  gold_assert(this->lock_count_ > 0);
+
+  File_read::View* pv = this->find_view(start, size);
+  if (pv != NULL)
+    {
+      memcpy(p, pv->data() + (start - pv->start()), size);
+      return;
+    }
+
+  this->do_read(start, size, p, NULL);
+}
+
+void
+File_read::read_up_to(off_t start, off_t size, void* p, off_t* pbytes)
 {
   gold_assert(this->lock_count_ > 0);
 
@@ -286,7 +303,15 @@ File_read::find_or_make_view(off_t start, off_t size, off_t* pbytes)
 // mmap.
 
 const unsigned char*
-File_read::get_view(off_t start, off_t size, off_t* pbytes)
+File_read::get_view(off_t start, off_t size)
+{
+  gold_assert(this->lock_count_ > 0);
+  File_read::View* pv = this->find_or_make_view(start, size, NULL);
+  return pv->data() + (start - pv->start());
+}
+
+const unsigned char*
+File_read::get_view_and_size(off_t start, off_t size, off_t* pbytes)
 {
   gold_assert(this->lock_count_ > 0);
   File_read::View* pv = this->find_or_make_view(start, size, pbytes);
@@ -294,10 +319,10 @@ File_read::get_view(off_t start, off_t size, off_t* pbytes)
 }
 
 File_view*
-File_read::get_lasting_view(off_t start, off_t size, off_t* pbytes)
+File_read::get_lasting_view(off_t start, off_t size)
 {
   gold_assert(this->lock_count_ > 0);
-  File_read::View* pv = this->find_or_make_view(start, size, pbytes);
+  File_read::View* pv = this->find_or_make_view(start, size, NULL);
   pv->lock();
   return new File_view(*this, pv, pv->data() + (start - pv->start()));
 }

diff --git a/gold/fileread.h b/gold/fileread.h
index b2bb46827fab2891254c62316748a29bb690fd34..a77721d47bb87e63e33023acbf6739b7eae2bca7 100644 (file)
--- a/gold/fileread.h
+++ b/gold/fileread.h
@@ -80,24 +80,37 @@ class File_read
   bool
   is_locked();
 
-  // Return a view into the file.  The pointer will remain valid until
-  // the File_read is unlocked.  If PBYTES is NULL, it is an error if
-  // we can not read enough data.  Otherwise *PBYTES is set to the
-  // number of bytes read.
+  // Return a view into the file starting at file offset START for
+  // SIZE bytes.  The pointer will remain valid until the File_read is
+  // unlocked.  It is an error if we can not read enough data from the
+  // file.
   const unsigned char*
-  get_view(off_t start, off_t size, off_t* pbytes = NULL);
+  get_view(off_t start, off_t size);
 
-  // Read data from the file into the buffer P.  PBYTES is as in
-  // get_view.
+  // Return a view into the file starting at file offset START, for up
+  // to SIZE bytes.  Set *PBYTES to the number of bytes read.  This
+  // may be less than SIZE.  The pointer will remain valid until the
+  // File_read is unlocked.
+  const unsigned char*
+  get_view_and_size(off_t start, off_t size, off_t* pbytes);
+
+  // Read data from the file into the buffer P starting at file offset
+  // START for SIZE bytes.
+  void
+  read(off_t start, off_t size, void* p);
+
+  // Read up to SIZE bytes from the file into the buffer P starting at
+  // file offset START.  Set *PBYTES to the number of bytes read.
   void
-  read(off_t start, off_t size, void* p, off_t* pbytes = NULL);
+  read_up_to(off_t start, off_t size, void* p, off_t* pbytes);
 
-  // Return a lasting view into the file.  This is allocated with new,
-  // and the caller is responsible for deleting it when done.  The
-  // data associated with this view will remain valid until the view
-  // is deleted.  PBYTES is handled as with get_view.
+  // Return a lasting view into the file starting at file offset START
+  // for SIZE bytes.  This is allocated with new, and the caller is
+  // responsible for deleting it when done.  The data associated with
+  // this view will remain valid until the view is deleted.  It is an
+  // error if we can not read enough data from the file.
   File_view*
-  get_lasting_view(off_t start, off_t size, off_t *pbytes = NULL);
+  get_lasting_view(off_t start, off_t size);
 
  private:
   // This class may not be copied.

diff --git a/gold/readsyms.cc b/gold/readsyms.cc
index 0e406fd5c24d51e28dfc8988cc96c0db890829cd..58e3385131b2f3bc2caf647a9fd45aa2b47ab80e 100644 (file)
--- a/gold/readsyms.cc
+++ b/gold/readsyms.cc
@@ -88,7 +88,8 @@ Read_symbols::run(Workqueue* workqueue)
 
   int ehdr_size = elfcpp::Elf_sizes<64>::ehdr_size;
   off_t bytes;
-  const unsigned char* p = input_file->file().get_view(0, ehdr_size, &bytes);
+  const unsigned char* p = input_file->file().get_view_and_size(0, ehdr_size,
+                                                               &bytes);
   if (bytes >= 4)
     {
       static unsigned char elfmagic[4] =

diff --git a/gold/script.cc b/gold/script.cc
index 582f6b76ff3b1ea90c82fa1434f77ba551e7ca04..53cd4931c57b998a59f53b7674adc5ff1f48ccf3 100644 (file)
--- a/gold/script.cc
+++ b/gold/script.cc
@@ -305,7 +305,7 @@ Lex::read_file(std::string* contents)
   unsigned char buf[BUFSIZ];
   do
     {
-      this->input_file_->file().read(off, sizeof buf, buf, &got);
+      this->input_file_->file().read_up_to(off, sizeof buf, buf, &got);
       contents->append(reinterpret_cast<char*>(&buf[0]), got);
       off += got;
     }