nir: fix warning in nir_lower_io.c
authorCaio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Tue, 8 Jan 2019 17:31:29 +0000 (09:31 -0800)
committerCaio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Tue, 8 Jan 2019 20:29:56 +0000 (12:29 -0800)
Initialize the variable with NULL.  Fixes the following

    In file included from ../src/compiler/nir/nir_lower_io.c:34:
    ../src/compiler/nir/nir_lower_io.c: In function ‘nir_lower_explicit_io’:
    ../src/compiler/nir/nir.h:668:11: warning: ‘addr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
        return src;
               ^~~
    ../src/compiler/nir/nir_lower_io.c:735:17: note: ‘addr’ was declared here
        nir_ssa_def *addr;
                     ^~~~

v2: Avoid using a 'default' case so we get help from the compiler when
    new deref types are added. (Lionel)

Acked-by: Jason Ekstrand <jason@jlekstrand.net>
src/compiler/nir/nir_lower_io.c

index bcbfebdfa3b75eedc89e32355c1d5630f4289398..44af76de599583b93d19b6fcaabfb97a1ea70191 100644 (file)
@@ -732,7 +732,7 @@ lower_explicit_io_deref(nir_builder *b, nir_deref_instr *deref,
    assert(deref->parent.is_ssa);
    nir_ssa_def *parent_addr = deref->parent.ssa;
 
-   nir_ssa_def *addr;
+   nir_ssa_def *addr = NULL;
    assert(deref->dest.is_ssa);
    switch (deref->deref_type) {
    case nir_deref_type_var: