anv: Link to libX11-xcb only when unneeded
authorChad Versace <chadversary@chromium.org>
Thu, 8 Sep 2016 03:07:50 +0000 (20:07 -0700)
committerChad Versace <chadversary@chromium.org>
Thu, 8 Sep 2016 16:24:30 +0000 (09:24 -0700)
The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
But it's needed only if HAVE_PLATFORM_X11.

Fixes build of libvulkan_intel.so on Chromium OS, which has no X11
libraries.

Fixes: 71258e9462c ("anv/x11: Add support for Xlib platform")
Cc: Kevin Strasser <kevin.strasser@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
src/intel/vulkan/Makefile.am

index 2d20de944d47d7335bf3c0fef53d1b52a8e8ad10..cf16ea4e2b196205576f3e957e9acce62dccd5be 100644 (file)
@@ -91,7 +91,9 @@ AM_CPPFLAGS += \
        -DVK_USE_PLATFORM_XLIB_KHR
 
 VULKAN_SOURCES += $(VULKAN_WSI_X11_FILES)
-VULKAN_LIB_DEPS += $(XCB_DRI3_LIBS)
+
+# FIXME: Use pkg-config for X11-xcb ldflags.
+VULKAN_LIB_DEPS += $(XCB_DRI3_LIBS) -lX11-xcb
 endif
 
 
@@ -149,7 +151,7 @@ EXTRA_DIST = \
        dev_icd.json.in \
        intel_icd.json
 
-libvulkan_intel_la_LIBADD = $(VULKAN_LIB_DEPS) -lX11-xcb
+libvulkan_intel_la_LIBADD = $(VULKAN_LIB_DEPS)
 
 libvulkan_intel_la_LDFLAGS = \
        -shared \
@@ -184,7 +186,7 @@ intel_icd.json : intel_icd.json.in
 
 # Libvulkan with dummy gem. Used for unit tests.
 libvulkan_test_la_SOURCES = $(VULKAN_GEM_STUB_FILES)
-libvulkan_test_la_LIBADD = $(VULKAN_LIB_DEPS) -lX11-xcb
+libvulkan_test_la_LIBADD = $(VULKAN_LIB_DEPS)
 
 include $(top_srcdir)/install-lib-links.mk