Mark section in a section group with SHF_GROUP

All sections in a section group should be marked with SHF_GROUP.  But
some tools generate broken objects without SHF_GROUP.  This patch fixes
them up for objcopy and strip.

	PR binutils/23199
	* elf.c (setup_group): Mark section in a section group with
	SHF_GROUP.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index bab543b9cefb341eb4950aae487dbe99a236c80b..7233851acd736ca46ae61e69e35d55b8b3e1c2ad 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2018-05-21  H.J. Lu  <hongjiu.lu@intel.com>
+
+       PR binutils/23199
+       * elf.c (setup_group): Mark section in a section group with
+       SHF_GROUP.
+
 2018-05-18  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR ld/23194

diff --git a/bfd/elf.c b/bfd/elf.c
index 47d046fa8346d2b47d32c94a12f700cbb7a8a461..6c66bbca02c8d857f3c76c02ef93bb4b1a7c4614 100644 (file)
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -711,7 +711,15 @@ setup_group (bfd *abfd, Elf_Internal_Shdr *hdr, asection *newsect)
                          break;
                        }
                      if (idx < shnum)
-                       dest->shdr = elf_elfsections (abfd)[idx];
+                       {
+                         dest->shdr = elf_elfsections (abfd)[idx];
+                         /* PR binutils/23199: All sections in a
+                            section group should be marked with
+                            SHF_GROUP.  But some tools generate
+                            broken objects without SHF_GROUP.  Fix
+                            them up here.  */
+                         dest->shdr->sh_flags |= SHF_GROUP;
+                       }
                      if (idx >= shnum
                          || dest->shdr->sh_type == SHT_GROUP)
                        {