style: Change maximum line length to 79 characters
authorAndreas Sandberg <andreas.sandberg@arm.com>
Wed, 30 Mar 2016 14:36:50 +0000 (15:36 +0100)
committerAndreas Sandberg <andreas.sandberg@arm.com>
Wed, 30 Mar 2016 14:36:50 +0000 (15:36 +0100)
The old style guide used to mandate 78 characters as the maximum line
length to accommodate traditional diffs on 80-column terminals. This
is an uncommon use case and it has therefore been decided (see email
thread on gem5-dev [1]) that a maximum length of 79-characters makes
more sense.

[1] http://comments.gmane.org/gmane.comp.emulators.m5.devel/29789

Signed-off-by: Andreas Sandberg <aandreas.sandberg@arm.com>
Reviewed-by: Brandon Potter <brandon.potter@amd.com>
--HG--
rename : util/style.py => util/hgstyle.py
extra : rebase_source : 63efcc4da2585ef8c323d6f322736f64d71742f8

util/style/verifiers.py

index 8626cc7ce4e68766f3ffea5b46576370296af53f..7650d307169df236efed4689df1c52dc84aa41da 100644 (file)
@@ -340,7 +340,7 @@ class LineLength(LineVerifier):
     opt_name = 'length'
 
     def check_line(self, line):
-        return style.normalized_len(line) <= 78
+        return style.normalized_len(line) <= 79
 
     def fix(self, filename, regions=all_regions):
         self.ui.write("Warning: cannot automatically fix overly long lines.\n")