2003-01-09 Andrew Cagney <ac131313@redhat.com>

	* somsolib.h: Fix function indentation.
	* disasm.c, buildsym.c, buildsym.h: Eliminate PTR.
	* gnu-v2-abi.c, f-typeprint.c, x86-64-linux-tdep.c: Eliminate STREQ.
	* demangle.c, ax-gdb.c, c-valprint.c: Eliminate STREQ.
	* alpha-osf1-tdep.c, corefile.c: Eliminate STREQ.
	* somsolib.c, inftarg.c: Remove assignment in if conditional.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 721e18fc96ad2e633c3e6cb38c3959b83b9174b5..8ca99a8d0c22e5eb097295b99e7343a56a13e57a 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
 2003-01-09  Andrew Cagney  <ac131313@redhat.com>
 
+       * somsolib.h: Fix function indentation.
+       * disasm.c, buildsym.c, buildsym.h: Eliminate PTR.
+       * gnu-v2-abi.c, f-typeprint.c, x86-64-linux-tdep.c: Eliminate STREQ.
+       * demangle.c, ax-gdb.c, c-valprint.c: Eliminate STREQ.
+       * alpha-osf1-tdep.c, corefile.c: Eliminate STREQ.
+       * somsolib.c, inftarg.c: Remove assignment in if conditional.
+
        * infrun.c (follow_fork): Use ISO C definition.
        * expprint.c (print_subexp): Use xfree instead of free.
        * charset.c: Include "gdb_string.h" instead of <string.h>.

diff --git a/gdb/alpha-osf1-tdep.c b/gdb/alpha-osf1-tdep.c
index 9a027d45b5c485cb977b097d74f76b5c12bf7f27..fa5bc5e41d09b465cfa0e39bc88cdfcc81b87fed 100644 (file)
--- a/gdb/alpha-osf1-tdep.c
+++ b/gdb/alpha-osf1-tdep.c
@@ -42,7 +42,7 @@ alpha_osf1_skip_sigtramp_frame (struct frame_info *frame, CORE_ADDR pc)
 static int
 alpha_osf1_pc_in_sigtramp (CORE_ADDR pc, char *func_name)
 {
-  return (func_name != NULL && STREQ ("__sigtramp", func_name));
+  return (func_name != NULL && strcmp ("__sigtramp", func_name) == 0);
 }
 
 static CORE_ADDR

diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c
index fa7066c7f96943924b7a3fa8468f73092a7efbfe..f2255f56498cde42a6f5aa9bf41b6e8330992e57 100644 (file)
--- a/gdb/ax-gdb.c
+++ b/gdb/ax-gdb.c
@@ -1157,7 +1157,7 @@ find_field (struct type *type, char *name)
     {
       char *this_name = TYPE_FIELD_NAME (type, i);
 
-      if (this_name && STREQ (name, this_name))
+      if (this_name && strcmp (name, this_name) == 0)
        return i;
 
       if (this_name[0] == '\0')

diff --git a/gdb/buildsym.c b/gdb/buildsym.c
index ffabe00eb84fce04d0b9be2f7f1471ee9af74fe6..eabf8a836703979d653caeaf2488a7061e3a7d84 100644 (file)
--- a/gdb/buildsym.c
+++ b/gdb/buildsym.c
@@ -152,7 +152,7 @@ find_symbol_in_list (struct pending *list, char *name, int length)
 
 /* ARGSUSED */
 void
-really_free_pendings (PTR dummy)
+really_free_pendings (void *dummy)
 {
   struct pending *next, *next1;
 

diff --git a/gdb/buildsym.h b/gdb/buildsym.h
index 51aeee75638aa06d8dd0b80f50561b795f1f24cd..b2a249c5574dc585de2a0f7543d41ac3776324d7 100644 (file)
--- a/gdb/buildsym.h
+++ b/gdb/buildsym.h
@@ -233,7 +233,7 @@ extern void finish_block (struct symbol *symbol,
                          CORE_ADDR start, CORE_ADDR end,
                          struct objfile *objfile);
 
-extern void really_free_pendings (PTR dummy);
+extern void really_free_pendings (void *dummy);
 
 extern void start_subfile (char *name, char *dirname);
 

diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c
index 925d9c5469c5f12142438f3f0628b5626505338f..e7c02cc061d61f13d8def84f166c558ef143a8f7 100644 (file)
--- a/gdb/c-valprint.c
+++ b/gdb/c-valprint.c
@@ -515,7 +515,7 @@ c_value_print (struct value *val, struct ui_file *stream, int format,
       if (TYPE_CODE (type) == TYPE_CODE_PTR &&
          TYPE_NAME (type) == NULL &&
          TYPE_NAME (TYPE_TARGET_TYPE (type)) != NULL &&
-         STREQ (TYPE_NAME (TYPE_TARGET_TYPE (type)), "char"))
+         strcmp (TYPE_NAME (TYPE_TARGET_TYPE (type)), "char") == 0)
        {
          /* Print nothing */
        }

diff --git a/gdb/corefile.c b/gdb/corefile.c
index be0ecf0e3b0fbec78df2dd80babff3b2a167b02e..b5256569a1e85a40aa3416be7adbd1b87fe802ca 100644 (file)
--- a/gdb/corefile.c
+++ b/gdb/corefile.c
@@ -439,7 +439,7 @@ static void set_gnutarget_command (char *, int, struct cmd_list_element *);
 static void
 set_gnutarget_command (char *ignore, int from_tty, struct cmd_list_element *c)
 {
-  if (STREQ (gnutarget_string, "auto"))
+  if (strcmp (gnutarget_string, "auto") == 0)
     gnutarget = NULL;
   else
     gnutarget = gnutarget_string;

diff --git a/gdb/demangle.c b/gdb/demangle.c
index 2b9579bc59ca7691396a1b57f746b5ace2306dbb..3df9684fe897e6b03badeaa909bdabb5bce5b2e0 100644 (file)
--- a/gdb/demangle.c
+++ b/gdb/demangle.c
@@ -87,8 +87,8 @@ set_demangling_command (char *ignore, int from_tty, struct cmd_list_element *c)
        dem->demangling_style != unknown_demangling; 
        dem++)
     {
-      if (STREQ (current_demangling_style_string,
-                dem->demangling_style_name))
+      if (strcmp (current_demangling_style_string,
+                 dem->demangling_style_name) == 0)
        {
          current_demangling_style = dem->demangling_style;
          break;

diff --git a/gdb/disasm.c b/gdb/disasm.c
index 8ce9a155166e455f18b39dc4ebea78a7ea7f9e7c..e69458d6e56d2468587fb4dbbd415d948bdd7e0b 100644 (file)
--- a/gdb/disasm.c
+++ b/gdb/disasm.c
@@ -66,7 +66,7 @@ gdb_dis_asm_read_memory (bfd_vma memaddr, bfd_byte * myaddr,
 }
 
 static int
-compare_lines (const PTR mle1p, const PTR mle2p)
+compare_lines (const void *mle1p, const void *mle2p)
 {
   struct dis_line_entry *mle1, *mle2;
   int val;

diff --git a/gdb/f-typeprint.c b/gdb/f-typeprint.c
index 2eba3912401bcf20878351dc7b216f2a07a42ed5..bd34b93b5ec2c2d03c162df6fc03f7642ddaaa4b 100644 (file)
--- a/gdb/f-typeprint.c
+++ b/gdb/f-typeprint.c
@@ -355,7 +355,7 @@ f_type_print_base (struct type *type, struct ui_file *stream, int show,
          through as TYPE_CODE_INT since dbxstclass.h is so
          C-oriented, we must change these to "character" from "char".  */
 
-      if (STREQ (TYPE_NAME (type), "char"))
+      if (strcmp (TYPE_NAME (type), "char") == 0)
        fprintf_filtered (stream, "character");
       else
        goto default_case;

diff --git a/gdb/gnu-v2-abi.c b/gdb/gnu-v2-abi.c
index fb31c44529f8580c69eba9061a913315d625e3aa..8ac78111fe2788e4cfdab6d4d3ae3043d1157214 100644 (file)
--- a/gdb/gnu-v2-abi.c
+++ b/gdb/gnu-v2-abi.c
@@ -329,8 +329,8 @@ vb_match (struct type *type, int index, struct type *basetype)
 
   if (TYPE_NAME (basetype) != NULL
       && TYPE_NAME (TYPE_TARGET_TYPE (fieldtype)) != NULL
-      && STREQ (TYPE_NAME (basetype),
-               TYPE_NAME (TYPE_TARGET_TYPE (fieldtype))))
+      && strcmp (TYPE_NAME (basetype),
+                TYPE_NAME (TYPE_TARGET_TYPE (fieldtype))) == 0)
     return 1;
   return 0;
 }

diff --git a/gdb/inftarg.c b/gdb/inftarg.c
index 471eb3cc7b5d959202f5fde6e8715fdbd7abf343..e12e8bd529ac70da0edbf9d1d766b12a5dc94632 100644 (file)
--- a/gdb/inftarg.c
+++ b/gdb/inftarg.c
@@ -649,7 +649,8 @@ _initialize_inftarg (void)
 #define PROC_NAME_FMT "/proc/%05d"
 #endif
   sprintf (procname, PROC_NAME_FMT, getpid ());
-  if ((fd = open (procname, O_RDONLY)) >= 0)
+  fd = open (procname, O_RDONLY);
+  if (fd >= 0)
     {
       close (fd);
       return;

diff --git a/gdb/somsolib.c b/gdb/somsolib.c
index 6cc9f45165794b21101d8fa43b0d0d9ce08c5ad1..3f74dce0a0cac5adc8c94b8a63f66c2a11cf35d2 100644 (file)
--- a/gdb/somsolib.c
+++ b/gdb/somsolib.c
@@ -418,7 +418,8 @@ som_solib_add (char *arg_string, int from_tty, struct target_ops *target, int re
   int threshold_warning_given = 0;
 
   /* First validate our arguments.  */
-  if ((re_err = re_comp (arg_string ? arg_string : ".")) != NULL)
+  re_err = re_comp (arg_string ? arg_string : ".");
+  if (re_err != NULL)
     {
       error ("Invalid regexp: %s", re_err);
     }

diff --git a/gdb/somsolib.h b/gdb/somsolib.h
index 4b23760199c419c5c7e28cab5f0e9cac30745aa5..60118b28bf7a4780d0d50cb2016f1800ad15ac60 100644 (file)
--- a/gdb/somsolib.h
+++ b/gdb/somsolib.h
@@ -36,8 +36,8 @@ extern void som_solib_add (char *, int, struct target_ops *, int);
 
 extern CORE_ADDR som_solib_get_got_by_pc (CORE_ADDR);
 
-extern int
-som_solib_section_offsets (struct objfile *, struct section_offsets *);
+extern int som_solib_section_offsets (struct objfile *,
+                                     struct section_offsets *);
 
 /* Function to be called when the inferior starts up, to discover the names
    of shared libraries that are dynamically linked, the base addresses to

diff --git a/gdb/x86-64-linux-tdep.c b/gdb/x86-64-linux-tdep.c
index bb127e0f46c41602065a901ce7877d1639275c61..c593abe88dabf87169f2caf87252702ce9945c7d 100644 (file)
--- a/gdb/x86-64-linux-tdep.c
+++ b/gdb/x86-64-linux-tdep.c
@@ -147,7 +147,7 @@ int
 x86_64_linux_in_sigtramp (CORE_ADDR pc, char *name)
 {
   if (name)
-    return STREQ ("__restore_rt", name);
+    return strcmp ("__restore_rt", name) == 0;
 
   return (x86_64_linux_sigtramp_start (pc) != 0);
 }