amd/common: Add some parentheses to silence warning.
authorBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Sat, 5 Jan 2019 16:45:01 +0000 (17:45 +0100)
committerBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Mon, 7 Jan 2019 22:15:37 +0000 (23:15 +0100)
[1/59] Compiling C object 'src/amd/common/src@amd@common@@amd_common@sta/ac_nir_to_llvm.c.o'.
../mesa/src/amd/common/ac_nir_to_llvm.c: In function ‘get_inst_tessfactor_writemask’:
../mesa/src/amd/common/ac_nir_to_llvm.c:4089:32: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses]
   writemask = ((1 << num_comps + 1) - 1) << first_component;
                      ~~~~~~~~~~^~~
../mesa/src/amd/common/ac_nir_to_llvm.c:4091:33: warning: suggest parentheses around ‘+’ inside ‘<<’ [-Wparentheses]
   writemask = (((1 << num_comps + 1) - 1) << first_component) << 4;

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
src/amd/common/ac_nir_to_llvm.c

index 8dea35178b36827195ba46c2e246384aae4d3982..5bf91b5171084b0a62804d7c9fa4110c4c6e540e 100644 (file)
@@ -4095,9 +4095,9 @@ get_inst_tessfactor_writemask(nir_intrinsic_instr *intrin)
        unsigned num_comps = intrin->dest.ssa.num_components;
 
        if (location == VARYING_SLOT_TESS_LEVEL_INNER)
-               writemask = ((1 << num_comps + 1) - 1) << first_component;
+               writemask = ((1 << (num_comps + 1)) - 1) << first_component;
        else if (location == VARYING_SLOT_TESS_LEVEL_OUTER)
-               writemask = (((1 << num_comps + 1) - 1) << first_component) << 4;
+               writemask = (((1 << (num_comps + 1)) - 1) << first_component) << 4;
 
        return writemask;
 }