package/lvm2: drop optional readline dependency
authorPeter Korsgaard <peter@korsgaard.com>
Wed, 13 Nov 2019 15:17:20 +0000 (16:17 +0100)
committerYann E. MORIN <yann.morin.1998@free.fr>
Wed, 13 Nov 2019 20:46:39 +0000 (21:46 +0100)
lvm2 is licensed under GPL-2.0, which is not license compatible with
readline (GPL-3.0+), so drop the optional dependency and add a comment
explaining why.

Notice: The readline support is only used when the raw lvm tool is called
without arguments.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
package/lvm2/lvm2.mk

index 7fdb9a7e3018ca31e553ce62a82f407974bdcf97..14575668a5b4b5b1e94f314e6a7d1633795f056e 100644 (file)
@@ -28,13 +28,8 @@ LVM2_DEPENDENCIES += host-pkgconf libaio
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
 
-ifeq ($(BR2_PACKAGE_READLINE),y)
-LVM2_DEPENDENCIES += readline
-else
-# v2.02.44: disable readline usage, or binaries are linked against provider
-# of "tgetent" (=> ncurses) even if it's not used..
+# package/readline is GPL-3.0+, so not license compatible
 LVM2_CONF_OPTS += --disable-readline
-endif
 
 ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
 LVM2_CONF_OPTS += --enable-selinux