Fix location for static class members

Consider the test case g++.dg/other/offsetof5.C:

    #include <stddef.h>

    struct A
    {
      char c;
      int &i;
    };

    int j = offsetof (A, i);		// { dg-warning "invalid access|offsetof" }

    template <typename T>
    struct S
    {
      T h;
      T &i;
      static const int j = offsetof (S, i);	// { dg-warning "invalid access|offsetof" }
    };

    int k = S<int>::j;			// { dg-message "required from here" }

The second warning (that involves the instantiation of the S template)
is not emitted when -ftrack-macro-expansion is on.

This is because during the instantiation of the member j of S
template, the location that is used for the warning is the one for the
DECL j (set by instantiate_decl).  And that location is inaccurately
set to the locus of 'offsetof', which is a macro defined in a system
header, so it's discarded by the diagnostics machinery.

Note that when we reach the point where we emit the warning in
build_class_member_access_expr offsetof expression has long been
folded, so we cannot use e.g, the location of the ')' token that would
have been in the source code.  So I believe the location of 'j' is the
best we can get at this point.

The patch below sets the location of the DECL for 'j' to what I
believe is its precise location; with that, the test case passes with
and without -ftrack-macro-expansion.  But I had to adjust
g++.dg/template/sfinae6_neg.C for that.

Tested on x86_64-unknown-linux-gnu against trunk.

gcc/cp

	* decl.c (grokdeclarator): Use the location carried by the
	declarator for the DECL of the static class member.

gcc/testsuite/

	* g++.dg/template/sfinae6_neg.C: Adjust.

From-SVN: r186974

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 06edc5007b0bb24c1a94ada82b970b8a90e27764..8d99c17fbf221a81f5364ee2c07071afb3a31fa3 100644 (file)
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,5 +1,9 @@
 2012-04-30  Dodji Seketeli  <dodji@redhat.com>
 
+       Fix location for static class members
+       * decl.c (grokdeclarator): Use the location carried by the
+       declarator for the DECL of the static class member.
+
        Fix va_arg type location
        * cp-tree.h (build_x_va_arg): Take an additional location
        parameter.

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 28c7cee4d90f981c836ddb326986402793335702..40818a3f3ff53d2674cb0d7c2f3cf7e5df9f987b 100644 (file)
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -10267,7 +10267,8 @@ grokdeclarator (const cp_declarator *declarator,
              {
                /* C++ allows static class members.  All other work
                   for this is done by grokfield.  */
-               decl = build_lang_decl (VAR_DECL, unqualified_id, type);
+               decl = build_lang_decl_loc (declarator->id_loc,
+                                           VAR_DECL, unqualified_id, type);
                set_linkage_for_static_data_member (decl);
                /* Even if there is an in-class initialization, DECL
                   is considered undefined until an out-of-class

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 4fda9ae5e003af6ce12644acfddc3fa0bebdb3ee..06f18f0c5827f318406507f7bb1cdb5947964e55 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2012-04-30  Dodji Seketeli  <dodji@redhat.com>
 
+       Fix location for static class members
+       * g++.dg/template/sfinae6_neg.C: Adjust.
+
        Make conversion warnings work on NULL with -ftrack-macro-expansion
        * g++.dg/warn/Wconversion-null-2.C: Add testing for __null,
        alongside the previous testing for NULL.

diff --git a/gcc/testsuite/g++.dg/template/sfinae6_neg.C b/gcc/testsuite/g++.dg/template/sfinae6_neg.C
index d4be5dd03f07f0c0f55c485414b27ab1ce910552..9b7bdfd134d5a47b8e2c9f745248f146f1ac4a09 100644 (file)
--- a/gcc/testsuite/g++.dg/template/sfinae6_neg.C
+++ b/gcc/testsuite/g++.dg/template/sfinae6_neg.C
@@ -21,9 +21,9 @@ no_type check_is_callable2(...);
 template<typename F, typename T1, typename T2 = T1>
 struct is_callable2
 {
-  static const bool value = 
+  static const bool value = // { dg-error "within this context" }
     (sizeof(check_is_callable2(type<F>(), type<T1>(), type<T2>()))
-     == sizeof(yes_type)); // { dg-error "within this context" }
+     == sizeof(yes_type));
 };
 
 #define JOIN( X, Y ) DO_JOIN( X, Y )